Bug 1778 - Redirect to circulation.pl doesn't always work when switching the library (redirect from selectbranchprinter.pl)
Summary: Redirect to circulation.pl doesn't always work when switching the library (re...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Chris Cormack
QA Contact: Bugs List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-18 02:33 UTC by Chris Nighswonger
Modified: 2016-06-19 20:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:34:29 UTC


---- Reported by cnighswonger@foundations.edu 2008-01-18 14:33:03 ----

1. Select the "Set" option on the Staff-client header bar.
2. Choose a library.
3. Click "Submit."
4. Find yourself at "Checkouts" with a blank main frame.

Not sure if this is a "bug" or a "feature request."

It looks like one should be returned to the originating screen.
Or at least to a populated "Checkouts" screen.



---- Additional Comments From oleonard@myacpl.org 2008-01-22 08:53:59 ----

Yeah, this technically qualifies as an enhancement request. The process you describe is working as intended. The selectbranchprinter script submits to circulation.pl to complete the branch-setting process. When circulation.pl loads, it loads without any particular patron data, so there is nothing displayed: the page is waiting for your input in the "check out" box at the top.

That said, I like the idea of being redirected to the referring page.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:34 UTC  ---

This bug was previously known as _bug_ 1778 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1778

Actual time not defined. Setting to 0.0

Comment 1 Katrin Fischer 2011-05-14 10:49:19 UTC
Tested on current master the user is still redirected to a blank circulation page after setting another library.
Comment 2 Marc Véron 2014-08-11 12:53:52 UTC
Tested on current master (3.17.00.013). 

Went to several pages (e.g. Reports, Reports>Items with no checkouts, Acquisitions...)
Changed Library with Set option in title bar

Result: Redirection back to orgination screen was OK.
Comment 3 Katrin Fischer 2016-06-19 20:15:48 UTC
Hm, this seems to work sometimes, but not always. I just tried from an open patron account in staff and ended on the blank 'checkouts' page. 

My guess it it happens when you do a search for the patron that forwards you directly to the patron's account (cardnumber for example) - the URL doesn't include a borrowernumber then. If you switch around tabs in the patron account and back to checkouts tab, the redirect does work.

Should we split this out into individual bugs for the pages it affects? 
Changing this one to be for the patron account as this sounds to be the issue from the initial description.
Comment 4 Chris Nighswonger 2016-06-19 20:38:37 UTC
Owen's comment to my original report is what happens (or happened) in the past. Redirecting to the patron account would not be desirable in all cases. For example, if I decide to set the branch when I am in one of the various other screens, I would not expect to end up back at the patron account screen, but rather at the screen I was originally at. So being redirected to the referring page would be the expected and desired action in all cases, IMHO.

Since this is an enhancement request, the original bug description was intended to reflect this. I think the current description implies that selecting this link should always result in being returned to the patron account page.
Comment 5 Katrin Fischer 2016-06-19 20:41:22 UTC
Hi Chris, 
it already redirects well in other cases - to the page you came from. I was just trying to reword this is a bit into an easier to fix bug for a known case that is not working :)