Bug 17816 - Useless call to GetBibioData in bulkmarcimport.pl(?)
Summary: Useless call to GetBibioData in bulkmarcimport.pl(?)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-27 12:46 UTC by David Gustafsson
Modified: 2018-12-03 20:05 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Gustafsson 2016-12-27 12:46:28 UTC
This call to GetBibioData seems without purpose: https://github.com/Koha-Community/Koha/blob/2fe2ef41bd8bf2f142597e39f493edbdbf75c8a3/misc/migration_tools/bulkmarcimport.pl#L418

$biblioitemnumber is either overwritten on the lines below, or update/create failed/was skipped and the later AddItemBatchFromMarc will fail anyways.
Comment 1 David Gustafsson 2016-12-27 12:51:42 UTC
Ok, seems like ModBiblio returns 1(!), not id and itemid. So the lvalues for ModBibilio must be removed. I think I saw another bug-report on this somewhere. Think this takes some more effort to fix, AddItemBatchFromMarc should only be run on insert, so the line can still be removed. But some further refactoring is also needed.