Bug 17969 - Refactor the way <<items.content>> is generated
Summary: Refactor the way <<items.content>> is generated
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Tomás Cohen Arazi
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 17967
  Show dependency treegraph
 
Reported: 2017-01-23 13:30 UTC by Jonathan Druart
Modified: 2017-08-08 17:59 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 17969: Refactor the way <<items.content>> is generated (7.65 KB, patch)
2017-01-23 14:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 17969: Refactor the way <<items.content>> is generated (7.82 KB, patch)
2017-03-25 08:39 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 17969: Refactor the way <<items.content>> is generated (7.80 KB, patch)
2017-06-05 16:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 17969: Refactor the way <<items.content>> is generated (7.80 KB, patch)
2017-07-31 16:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 17969: Refactor the way <<items.content>> is generated (7.83 KB, patch)
2017-08-07 15:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 17969: (QA followup) Add POD (1.08 KB, patch)
2017-08-07 15:15 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 17969: Refactor the way <<items.content>> is generated (7.89 KB, patch)
2017-08-08 17:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 17969: (QA followup) Add POD (1.14 KB, patch)
2017-08-08 17:59 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2017-01-23 13:30:11 UTC
<<items.content>> is generated 4x in advance_notices.pl and once in overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it testable and reusable.
Comment 1 Jonathan Druart 2017-01-23 14:02:09 UTC
Created attachment 59414 [details] [review]
Bug 17969: Refactor the way <<items.content>> is generated

<<items.content>> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <<items.content>> tag for advance and overdue notices.
The generated notices must be the same as before this patch.
Comment 2 Marc Véron 2017-03-25 08:39:14 UTC
Created attachment 61637 [details] [review]
Bug 17969: Refactor the way <<items.content>> is generated

<<items.content>> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <<items.content>> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 3 Jonathan Druart 2017-06-05 16:45:58 UTC
Created attachment 63976 [details] [review]
Bug 17969: Refactor the way <<items.content>> is generated

<<items.content>> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <<items.content>> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 4 Nick Clemens 2017-07-31 12:05:45 UTC
fatal: sha1 information is lacking or useless (C4/Letters.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 17969: Refactor the way <<items.content>> is generated
Comment 5 Jonathan Druart 2017-07-31 16:39:18 UTC
Created attachment 65364 [details] [review]
Bug 17969: Refactor the way <<items.content>> is generated

<<items.content>> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <<items.content>> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 6 Tomás Cohen Arazi 2017-08-07 15:14:55 UTC
Created attachment 65567 [details] [review]
Bug 17969: Refactor the way <<items.content>> is generated

<<items.content>> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <<items.content>> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Tomás Cohen Arazi 2017-08-07 15:15:01 UTC
Created attachment 65568 [details] [review]
Bug 17969: (QA followup) Add POD

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 8 Kyle M Hall 2017-08-08 17:59:13 UTC
Created attachment 65684 [details] [review]
Bug 17969: Refactor the way <<items.content>> is generated

<<items.content>> is generated 4x in advance_notices.pl and once in
overdue_notices.pl
It would be better to have it in C4::Letters.
It will enforce the fact that it already has the same behavior, make it
testable and reusable.

Test plan:
Use the <<items.content>> tag for advance and overdue notices.
The generated notices must be the same as before this patch.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall 2017-08-08 17:59:20 UTC
Created attachment 65685 [details] [review]
Bug 17969: (QA followup) Add POD

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>