Rather than a free text syspref where a user can easily put in a category that doesn't exist.
Created attachment 59591 [details] [review] Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category code from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=17897
Created attachment 59592 [details] [review] Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category code from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT
Could this show the description instead of the code?
Created attachment 59635 [details] [review] Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT
Created attachment 59640 [details] [review] Bug 17987: Changing PatronSelfRegistrationDefaultCategory to a dropdown menu syspref This removes the chance of a librarian putting in a patron category that does not exist and having PatronSelfRegistrationDefaultCategory default to the first category in the list. To test: 1) Put a false category code into the PatronSelfRegistrationDefaultCategory syspref 2) Go to the OPAC to self register 3) Notice the selected category type is just the first category in the list (alphabetically) 4) Apply patch and update database 5) Go back to the PatronSelfRegistrationDefaultCategory syspref 6) Select a category from the dropdown and save 7) Go back to the OPAC and attempt to self register 8) Confirm that the correct category is now showing Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Hi Aleisha, Here are a few remarks: 1/ in the preferences.pl file, I think it would be better to affect the patron category list to $chunk->{'CHOICES'} if the type of the syspref is patron-categories, and not depending on its name. That way it will be reusable more easily. 2/ There is type=PatronCategories"in the DB, choices:patron-categories in the opac.pref, then choices eq 'patron-categories' in preferences.pl How is useful this type=PatronCategories? 3/ There are 2 problematic cases: a. The field is not filled yet: it's not visible on the interface, there is no blank entry b. A bit more tricky: if the patron category has been removed, it will not be displayed.
*** This bug has been marked as a duplicate of bug 27634 ***