Buttons should use bootstrap 3
Created attachment 59836 [details] [review] Bug 18042: Updating buttons in batch record modification and deletion To test: Create a test record that you can edit and delete. Go through each process of modifying the record, then deleting the record - once before applying the patch, and after apply the patch. Notice the difference in buttons and confirm they all still work as expected. Sponsored-by: Catalyst IT
I am for fa icon on Delete and Modify buttons, for submit buttons we should probably start using btn-primary class, as Owen used in his restyling webinstaller work. ccing Owen to have his comment here, thanks ;)
Created attachment 59959 [details] [review] Bug 18042: Updating buttons in batch record modification and deletion To test: Create a test record that you can edit and delete. Go through each process of modifying the record, then deleting the record - once before applying the patch, and after apply the patch. Notice the difference in buttons and confirm they all still work as expected. Sponsored-by: Catalyst IT
Tested bug #18042 on 2/9/2017 using ByWater Sandbox. Steps taken: 1.) Koha Cataloging > New Record on Default Framework. 2.) Using the simple editor, filled in these MARC fields: 000, 005, 006, 007, 008, 020, 100, 245, 300, 650 tied to one authority record, 942$c for BOOK. 3.) Saved the new record. Koha prompted me to fill in the required fields: 003 and 040. Then saved 4.) Koha prompts me to create a new item (Add item). Fields filled in include: 952$3, $8, $d, $p, $y, $t, $v. Add item was successful. 5.) Test record is now done. #439. 6.) Search to find two more bib numbers: #171, #272. 7.) Koha > Tools > Batch Record Modification. Received the message: " No MARC modification template is defined. You have to create at least one template for this tool. 8.) Click Manage MARC Modification Templates. Message here is "There are no defined templates. Please create a template first. 9.) Tools>MARC Modification templates > New Template created. Add in New Action. I like the new buttons. 10.) Under Add a new action, Add/Update 942$n with value 1. Add action. 11.) Add in a second action to new template. Add/update 650 x with value Massachusetts. Add Action. 12.) Click on Batch Record Modification. Selected option to enter a list of three bib numbers: 439, 171, 272. Select modification template and Continue. 13.) Next screen gives me a new area where users can still DESELECT individual records which is nice. There is a SHOW MARC button which is also nice. Show MARC does pop up dialog with MARC fields.... 14.) I clicked Modify selected records. I receive a message that the three bibs were successfully modified. Prompted to do a new batch record modification..... 15.) I click on record #171. I go to edit bib mode. I see 942$n has a 1. 650 has a $x for Massachusetts. 16.) I click on Batch record deletion under Tools. 17.) I enter in a list of three bib numbers: 439, 171, 272. I click Continue. Buttons look clean. 18.) Next screen for batch record deletion gives me the option to deselect individual records; select all, clear all, select without holds, select without items. I clicked Delete selected records. Success. Prompted to do another batch record deletion. 19.) I search for deleted bibs but they are removed. Functionality and buttons work well. jls. 19.
(In reply to Josef Moravec from comment #2) > > for submit buttons we should probably start using btn-primary class, as Owen > used in his restyling webinstaller work. Thanks for asking Josef. I usually don't catch Bugzilla CC's so if you think of it @later me on IRC with questions. I really think we need to come up with a comprehensive plan for updating buttons. As I commented on Bug 17873, I think we need to get proposals for how different kinds of buttons are going to be updated: https://wiki.koha-community.org/wiki/Interface_patterns#Buttons My initial thoughts about this process: - I think we should come up with updates to the default Bootstrap button styles if we are going to use more than the btn-default class. Bootstrap colors aren't designed to work with Koha's, and we should avoid looking like out-of-the-box Bootstrap. - I don't think we should add icons to all buttons. I think the icons are useful in places where there are multiple buttons which need to be distinguished from each other. I think submit buttons all serve a single basic purpose which doesn't require an added icon. Those are just my opinions of course. I think we should work together to come up with a real style guide.
Verified all the buttons are now btn-primary or appear in the new staff redesign 'yellow' for the main action. I agree with Owen about the icons for form submits.