As suggested in Bug 13205 Comment 1
Created attachment 60301 [details] [review] Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT
The patch 13205 apply perfectly. There is no problem jumping from any page to first/last/next/previous page on OPAC or staff client.
Blocked by bug 13205.
Created attachment 64940 [details] [review] Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT
Created attachment 64980 [details] [review] Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Hi Aleisha, When I try this with a bunch of pages (218) the dropdown only lists the visible pages. If I select page 10, then the pages i can select goes up to 20 as does the dropdown, but the screen is very crowded. screenshot to follow My assumption was the dropdown would go from first page # to last page # and the bar would always be 5 on either side?
Created attachment 67778 [details] after selecting page 10
Created attachment 68306 [details] [review] Bug 18128: [FOLLOW-UP] Some display fixes This patch addresses some of the display issues brought up in Comment 6. The dropdown list should now include every page number. The bar will only show up to 5 page numbers on each side of the current active page.
(In reply to Nick Clemens from comment #6) > Hi Aleisha, > > When I try this with a bunch of pages (218) the dropdown only lists the > visible pages. If I select page 10, then the pages i can select goes up to > 20 as does the dropdown, but the screen is very crowded. screenshot to follow > > My assumption was the dropdown would go from first page # to last page # and > the bar would always be 5 on either side? Hi Nick Thanks for pointing this out! I've added a follow-up patch that you can test. hopefully this is more to your liking.
Created attachment 68325 [details] [review] Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 68326 [details] [review] Bug 18128: [FOLLOW-UP] Some display fixes This patch addresses some of the display issues brought up in Comment 6. The dropdown list should now include every page number. The bar will only show up to 5 page numbers on each side of the current active page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 68720 [details] [review] Bug 18128: Go to page option for search results in OPAC and staff This patch adds a dropdown of all available search result pages for a user to jump to. To test: 1) Apply Bug 13205 2) Do a search in OPAC and in staff client 3) Try to jump to different pages in the dropdown, confirm they always work Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 68721 [details] [review] Bug 18128: [FOLLOW-UP] Some display fixes This patch addresses some of the display issues brought up in Comment 6. The dropdown list should now include every page number. The bar will only show up to 5 page numbers on each side of the current active page. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Fixed conflict with bug 19461
I see only 1 page, maybe I messed up the rebase. (In reply to Nick Clemens from comment #11) > Created attachment 68326 [details] [review] [review] > Bug 18128: [FOLLOW-UP] Some display fixes > > This patch addresses some of the display issues brought up in Comment 6. > > The dropdown list should now include every page number. > The bar will only show up to 5 page numbers on each side of the current > active page. Why? 10 was good number IMO. I'd like more opinion about this change.