Bug 18128 - 'Go to page' option for search results in opac and staff
Summary: 'Go to page' option for search results in opac and staff
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on: 13205
Blocks:
  Show dependency treegraph
 
Reported: 2017-02-16 03:29 UTC by Aleisha Amohia
Modified: 2018-06-04 19:13 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18128: Go to page option for search results in OPAC and staff (7.35 KB, patch)
2017-02-16 03:32 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18128: Go to page option for search results in OPAC and staff (4.74 KB, patch)
2017-07-10 00:39 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18128: Go to page option for search results in OPAC and staff (4.79 KB, patch)
2017-07-10 19:25 UTC, Lee Jamison
Details | Diff | Splinter Review
after selecting page 10 (10.96 KB, image/png)
2017-10-07 01:43 UTC, Nick Clemens
Details
Bug 18128: [FOLLOW-UP] Some display fixes (10.53 KB, patch)
2017-10-20 01:51 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18128: Go to page option for search results in OPAC and staff (4.85 KB, patch)
2017-10-20 15:34 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18128: [FOLLOW-UP] Some display fixes (10.59 KB, patch)
2017-10-20 15:34 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18128: Go to page option for search results in OPAC and staff (4.85 KB, patch)
2017-10-27 14:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 18128: [FOLLOW-UP] Some display fixes (10.61 KB, patch)
2017-10-27 14:17 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2017-02-16 03:29:54 UTC
As suggested in Bug 13205 Comment 1
Comment 1 Aleisha Amohia 2017-02-16 03:32:13 UTC
Created attachment 60301 [details] [review]
Bug 18128: Go to page option for search results in OPAC and staff

This patch adds a dropdown of all available search result pages for a
user to jump to.

To test:
1) Apply Bug 13205
2) Do a search in OPAC and in staff client
3) Try to jump to different pages in the dropdown, confirm they always
work

Sponsored-by: Catalyst IT
Comment 2 Séverine Queune 2017-03-24 11:32:16 UTC
The patch 13205 apply perfectly.
There is no problem jumping from any page to first/last/next/previous page on OPAC or staff client.
Comment 3 Jonathan Druart 2017-03-29 18:09:57 UTC
Blocked by bug 13205.
Comment 4 Aleisha Amohia 2017-07-10 00:39:35 UTC
Created attachment 64940 [details] [review]
Bug 18128: Go to page option for search results in OPAC and staff

This patch adds a dropdown of all available search result pages for a
user to jump to.

To test:
1) Apply Bug 13205
2) Do a search in OPAC and in staff client
3) Try to jump to different pages in the dropdown, confirm they always
work

Sponsored-by: Catalyst IT
Comment 5 Lee Jamison 2017-07-10 19:25:22 UTC
Created attachment 64980 [details] [review]
Bug 18128: Go to page option for search results in OPAC and staff

This patch adds a dropdown of all available search result pages for a
user to jump to.

To test:
1) Apply Bug 13205
2) Do a search in OPAC and in staff client
3) Try to jump to different pages in the dropdown, confirm they always
work

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Comment 6 Nick Clemens 2017-10-07 01:43:19 UTC
Hi Aleisha,

When I try this with a bunch of pages (218) the dropdown only lists the visible pages. If I select page 10, then the pages i can select goes up to 20 as does the dropdown, but the screen is very crowded. screenshot to follow

My assumption was the dropdown would go from first page # to last page # and the bar would always be 5 on either side?
Comment 7 Nick Clemens 2017-10-07 01:43:41 UTC
Created attachment 67778 [details]
after selecting page 10
Comment 8 Aleisha Amohia 2017-10-20 01:51:06 UTC
Created attachment 68306 [details] [review]
Bug 18128: [FOLLOW-UP] Some display fixes

This patch addresses some of the display issues brought up in Comment 6.

The dropdown list should now include every page number.
The bar will only show up to 5 page numbers on each side of the current
active page.
Comment 9 Aleisha Amohia 2017-10-20 01:51:46 UTC
(In reply to Nick Clemens from comment #6)
> Hi Aleisha,
> 
> When I try this with a bunch of pages (218) the dropdown only lists the
> visible pages. If I select page 10, then the pages i can select goes up to
> 20 as does the dropdown, but the screen is very crowded. screenshot to follow
> 
> My assumption was the dropdown would go from first page # to last page # and
> the bar would always be 5 on either side?

Hi Nick

Thanks for pointing this out! I've added a follow-up patch that you can test. hopefully this is more to your liking.
Comment 10 Nick Clemens 2017-10-20 15:34:16 UTC
Created attachment 68325 [details] [review]
Bug 18128: Go to page option for search results in OPAC and staff

This patch adds a dropdown of all available search result pages for a
user to jump to.

To test:
1) Apply Bug 13205
2) Do a search in OPAC and in staff client
3) Try to jump to different pages in the dropdown, confirm they always
work

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 11 Nick Clemens 2017-10-20 15:34:19 UTC
Created attachment 68326 [details] [review]
Bug 18128: [FOLLOW-UP] Some display fixes

This patch addresses some of the display issues brought up in Comment 6.

The dropdown list should now include every page number.
The bar will only show up to 5 page numbers on each side of the current
active page.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 12 Jonathan Druart 2017-10-27 14:17:38 UTC
Created attachment 68720 [details] [review]
Bug 18128: Go to page option for search results in OPAC and staff

This patch adds a dropdown of all available search result pages for a
user to jump to.

To test:
1) Apply Bug 13205
2) Do a search in OPAC and in staff client
3) Try to jump to different pages in the dropdown, confirm they always
work

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 13 Jonathan Druart 2017-10-27 14:17:42 UTC
Created attachment 68721 [details] [review]
Bug 18128: [FOLLOW-UP] Some display fixes

This patch addresses some of the display issues brought up in Comment 6.

The dropdown list should now include every page number.
The bar will only show up to 5 page numbers on each side of the current
active page.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 14 Jonathan Druart 2017-10-27 14:18:29 UTC
Fixed conflict with bug 19461
Comment 15 Jonathan Druart 2017-10-27 16:53:59 UTC
I see only 1 page, maybe I messed up the rebase.

(In reply to Nick Clemens from comment #11)
> Created attachment 68326 [details] [review] [review]
> Bug 18128: [FOLLOW-UP] Some display fixes
> 
> This patch addresses some of the display issues brought up in Comment 6.
> 
> The dropdown list should now include every page number.
> The bar will only show up to 5 page numbers on each side of the current
> active page.

Why? 10 was good number IMO.
I'd like more opinion about this change.