Created attachment 60697 [details] [review] Bug 18174: Add update to Koha::Object Still work in progress
Created attachment 60698 [details] [review] Bug 18174: Add update to Koha::Object Since Koha::Objects has a update method, we should allow it too in Koha::Object. Note that it is just redirecting to DBIx immediately. We also differentiate between a method that does not exist, and a method that generated an error. Test plan: Run t/db_dependent/Koha/Object.t
Created attachment 60699 [details] [review] Bug 18174: Add update to Koha::Object Since Koha::Objects has a update method, we should allow it too in Koha::Object. Note that it is just redirecting to DBIx immediately. Changed the exception when the method generates an error. The previous code suggested that the method was not found, but this is not the case. Test plan: Run t/db_dependent/Koha/Object.t
Created attachment 60721 [details] [review] Bug 18174: Add update to Koha::Object Since Koha::Objects has a update method, we should allow it too in Koha::Object. Note that it is just redirecting to DBIx immediately. Changed the exception when the method generates an error. The previous code suggested that the method was not found, but this is not the case. Test plan: Run t/db_dependent/Koha/Object.t Followed test plan, tests passes OK. Signed-off-by: Marc Véron <veron@veron.ch>
(In reply to Marc Véron from comment #4) > Signed-off-by: Marc Véron <veron@veron.ch> Thanks, Marc
Created attachment 60889 [details] [review] Bug 18174: Add update to Koha::Object Since Koha::Objects has a update method, we should allow it too in Koha::Object. Note that it is just redirecting to DBIx immediately. Changed the exception when the method generates an error. The previous code suggested that the method was not found, but this is not the case. Test plan: Run t/db_dependent/Koha/Object.t Followed test plan, tests passes OK. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Marcel!
This won't get ported back to 16.11.x as it is an enhancement.