Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print"
Summary: Koha::Logger utf8 handling defeating "wide characters in print"
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-08 10:49 UTC by Olli-Antti Kivilahti
Modified: 2017-10-15 11:51 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print" (2.45 KB, patch)
2017-03-08 10:52 UTC, Olli-Antti Kivilahti
Details | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2017-03-08 10:49:53 UTC
One must explicitly tell the Log4perl-appenders to deal with utf8.
Poor Log4perl.
Poor utf8 in Perl.

this patch adds utf8=1 to log4perl.conf
Comment 1 Olli-Antti Kivilahti 2017-03-08 10:52:28 UTC
Created attachment 60912 [details] [review]
Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print"

No more wide characters in print when logging to a file with Koha::Logger.

Test with this string

"♯Turpo :"
Comment 2 Katrin Fischer 2017-10-15 11:49:53 UTC
Patch no longer applies (missing dependency?):

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print"
fatal: sha1 information is lacking or useless (etc/log4perl.conf).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 18227 - Koha::Logger utf8 handling defeating "wide characters in print"
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-18227---KohaLogger-utf8-handling-defeating-wid-VJmYgV.patch
Comment 3 Katrin Fischer 2017-10-15 11:51:33 UTC
Assigning to Olli-Antti as he provided the patch.