Bug 18237 - Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60.
Summary: Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data....
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on: 5630
Blocks:
  Show dependency tree / graph
 
Reported: 2017-03-09 12:25 UTC by Olli-Antti Kivilahti
Modified: 2018-04-19 14:50 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 18237 - Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60. (1.12 KB, patch)
2017-03-09 12:26 UTC, Olli-Antti Kivilahti 		Details | Diff | Splinter Review
Bug 11674: DBRev 17.12.00.031 (2.93 KB, patch)
2018-04-17 19:36 UTC, Séverine Queune 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2017-03-09 12:25:18 UTC 
Fixes
    t/db_dependent/00-strict.t
Comment 1 Olli-Antti Kivilahti 2017-03-09 12:26:01 UTC 
Created attachment 60944 [details] [review]
Bug 18237 - Can't use a hash as a reference at docs/CAS/CASProxy/examples/proxy_cas_data.pl line 60.

Fixes t/db_dependent/00-strict.t
Comment 2 Olli-Antti Kivilahti 2017-03-09 12:27:48 UTC 
root@koha_ci_1:/home/koha/Koha# cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.1 LTS"
root@koha_ci_1:/home/koha/Koha# perl -v

This is perl 5, version 22, subversion 1 (v5.22.1) built for x86_64-linux-gnu-thread-multi
Comment 3 Jonathan Druart 2017-09-26 18:28:04 UTC 
Looks like the fix is more

-      my $pgtId = %$hashref->{$cgi->param('PGTIOU')};
+      my $pgtId = $hashref->{$cgi->param('PGTIOU')};

instead of
-      my $pgtId = %$hashref->{$cgi->param('PGTIOU')};
+      my $pgtId = %{$hashref->{$cgi->param('PGTIOU')}};
Comment 4 Séverine Queune 2018-04-17 19:36:43 UTC 
Created attachment 74387 [details] [review]
Bug 11674: DBRev 17.12.00.031

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Séverine Queune 2018-04-17 19:40:51 UTC 
(In reply to Séverine Queune from comment #4)
> Created attachment 74387 [details] [review] [review]
> Bug 11674: DBRev 17.12.00.031
> 
> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

I'm soooo sorry !! I wrote 18237 instead of 18327 when I signed it....
I set it back to "ASSIGNED"