Bug 18257 - Column visibility button does not increase colspan properly with pre-hidden columns
Summary: Column visibility button does not increase colspan properly with pre-hidden c...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-13 17:51 UTC by Christopher Brannon
Modified: 2017-04-19 17:44 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot with broken colspan... (28.66 KB, image/png)
2017-04-19 17:43 UTC, Marc Véron
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2017-03-13 17:51:50 UTC
When toggling a column that is hidden by default in circulation.pl and moremember.pl, the "Today's checkouts" and "Previous checkouts" cells do not expand correctly.

To test:
1) Go to circulation.pl and checkout an item.
2) Hide a column.  See that the "Today's checkouts" cell is the correct length.
3) Show the hidden column.  See that the cell is still the correct length.
4) Go to columns_settings.pl --> issues-table and hide one of the columns by default.
5) Go back to circulation.pl and show that hidden column.  See that the "Today's checkouts" cell is shorter than the row.
Comment 1 Christopher Brannon 2017-03-14 20:17:38 UTC
I'm looking at the possibility of changing the nature of the tables a touch.  Right now, the tables completely remove the columns.  I am looking to see if they can just be hidden.  The problem is that when the columns are hidden by default, the Column Visibility feature does not know how many columns are hidden by default.  I have a desire to retain the columns hidden, so I can use the information in those cells for another feature I have in the works.

This is open for discussion.
Comment 2 Jonathan Druart 2017-03-21 15:45:09 UTC
(In reply to Christopher Brannon from comment #1)
> I have a desire to retain the columns hidden, so I can
> use the information in those cells for another feature I have in the works.

Which is?
Comment 3 Christopher Brannon 2017-03-21 17:33:10 UTC
(In reply to Jonathan Druart from comment #2)
> (In reply to Christopher Brannon from comment #1)
> > I have a desire to retain the columns hidden, so I can
> > use the information in those cells for another feature I have in the works.
> 
> Which is?

Maintaining the columns and hiding them will allow us to more easily compensate for this bug this ticket addresses, in my opinion, and will allow a feature I am looking into developing.  

That feature is to give the added choice of showing the hidden information in a popover while hovering over the row.  Having the columns hidden instead of removed allows me to repurpose the data without having to invent another method of bringing that information back to the page.

The idea is that there is a lot of clutter on the checkout rows that people don't need all the time in the normal checkout workflow, which is why some people turn off certain columns.  However, someone might still occasionally need a piece of information, and they can simply hover their mouse over the row to read it.

I have a working concept in jquery, but I think it would be a good permanent enhancement to try.
Comment 4 Marc Véron 2017-04-19 17:43:58 UTC
Created attachment 62404 [details]
Screenshot with broken colspan...

Screenshot from Bug 18453 as illustration for froken colspan