Bug 18306 - "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it
Summary: "Renew selected" and "renew all" in OPAC can be confusing for users not allow...
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 16.11
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-20 18:48 UTC by Alexandre
Modified: 2019-05-15 15:01 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
renew buttons circled in red (91.15 KB, image/png)
2017-03-20 18:48 UTC, Alexandre
Details
error message with renew button in 16.11 (95.87 KB, image/png)
2017-03-21 15:15 UTC, Alexandre
Details
Bug 18306: "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it (4.66 KB, patch)
2019-03-21 16:49 UTC, Owen Leonard
Details | Diff | Splinter Review
not renewable (105.82 KB, image/png)
2019-03-21 17:20 UTC, Marjorie Barry-Vila
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre 2017-03-20 18:48:16 UTC
Created attachment 61338 [details]
renew buttons circled in red

Hi,

Some of our staff users reports that when students are doing a search in the OPAC, the buttons "Renew selected" and "Renew all" are confusing for them (circled in red). They think they are able to renew their books but in fact they aren't allowed to do this.

The problem is when the "OpacRenewalAllowed" is disabled, these buttons stay there and/or keep the same appearance.

Thanks for helping,

Alexandre from CCSR
Comment 1 Marc Véron 2017-03-21 08:03:00 UTC
Hi Alexandre,

I can not reproduce on current master. What Koha version is it?

Marc
Comment 2 Alexandre 2017-03-21 14:02:13 UTC
Hi Marc,

We use v3.22, we will soon pass to 16.05 however.

Thanks for helping,
Comment 3 Alexandre 2017-03-21 14:51:24 UTC
Very sorry for this second post.

After a discussion with my collegue Marjorie, it's appears that this bug is in 16.11 too.
Comment 4 Alexandre 2017-03-21 15:13:51 UTC
I just tested it in 16.11 too, they still there.

We can also observe an error message (in yellow) when we try the "renew all" button (see second picture): 

" Your loan renewal failed because of the following reason(s): You have renewed this item the maximum number of times allowed. You have renewed this item the maximum number of times allowed."

I must admit that can be very confusing for a student. These buttons let the student think that they can renew their books by themself and at home (OPAC) but they will realise just in the last days of their loans that they can't... This message don't help them to understand the situation.

Marc, which version did you use ? Maybe it was corrected for 17.05 but I didn't see any bug on this.
Comment 5 Alexandre 2017-03-21 15:15:21 UTC
Created attachment 61400 [details]
error message with renew button in 16.11
Comment 6 Marc Véron 2017-03-22 10:23:13 UTC
(In reply to Alexandre from comment #4)
(...)
> Marc, which version did you use ? Maybe it was corrected for 17.05 but I
> didn't see any bug on this.
Current master (16.12.00.013)
Comment 7 Owen Leonard 2017-04-26 17:27:38 UTC
I don't know if it's the only condition which creates the problem, but I see that having OverduesBlockRenewing set to 'block' or 'blockitem' can lead to a situation where the renew links are displayed but no checkboxes appear.
Comment 8 Marjorie Barry-Vila 2019-03-19 13:38:26 UTC
Still valid in 18.05

Marjorie
Comment 9 Owen Leonard 2019-03-21 16:49:56 UTC
Created attachment 86853 [details] [review]
Bug 18306: "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it

This patch add additional checks to opac-user.pl defining the ability to
renew some or all items. The template can now better check whether it
should show the renewal controls.

To test, apply the patch and log in to the OPAC as a user with multiple
checkouts. Test the following conditions:

 - All checkouts can be renewed
   - "Renew selected" and "Renew all" should appear at the top and
     bottom of the table of checkouts.
 - No checkouts can be renewed
   - No renewal controls should appear.
 - Some checkouts can be renewed
   - "Renew selected" should appear but not "Renew all"

Test with various settings of the OverduesBlockRenewing system
preference.
Comment 10 Marjorie Barry-Vila 2019-03-21 17:19:54 UTC
(In reply to Owen Leonard from comment #9)
> Created attachment 86853 [details] [review] [review]
> Bug 18306: "Renew selected" and "renew all" in OPAC can be confusing for
> users not allowed to do it
> 
> This patch add additional checks to opac-user.pl defining the ability to
> renew some or all items. The template can now better check whether it
> should show the renewal controls.
> 
> To test, apply the patch and log in to the OPAC as a user with multiple
> checkouts. Test the following conditions:
> 
>  - All checkouts can be renewed
>    - "Renew selected" and "Renew all" should appear at the top and
>      bottom of the table of checkouts.
>  - No checkouts can be renewed
>    - No renewal controls should appear.
>  - Some checkouts can be renewed
>    - "Renew selected" should appear but not "Renew all"
> 
> Test with various settings of the OverduesBlockRenewing system
> preference.

Hi Owen,
I tested it on sandbox http://catalogue.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/opac-user.pl and link Renew selected still appears even if all my checkout are not renewable.
OverduesBlockRenewing is set on allow renewing

Regards,
Marjorie
Comment 11 Marjorie Barry-Vila 2019-03-21 17:20:44 UTC
Created attachment 86855 [details]
not renewable
Comment 12 Owen Leonard 2019-03-21 17:37:13 UTC
(In reply to Marjorie Barry-Vila from comment #10)

> even if all my checkout are not renewable.

Why are your checkouts not renewable?
Comment 13 Marjorie Barry-Vila 2019-03-21 18:03:09 UTC
(In reply to Owen Leonard from comment #12)
> (In reply to Marjorie Barry-Vila from comment #10)
> 
> > even if all my checkout are not renewable.
> 
> Why are your checkouts not renewable?

I used all the renewals available according to the circulation rules.

Marjorie
Comment 14 Liz Rea 2019-05-15 15:01:33 UTC
I see this too, renew selected appears even if there are no items available to renew.

It seems to work correctly when  OverduesBlockRenewing is set to block.

Sorry Owen. :(