Bug 18345 - Add a more ES based query builder
Summary: Add a more ES based query builder
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-28 14:08 UTC by Nick Clemens
Modified: 2018-03-02 15:11 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18345 - Add a more ES based query builder (2.88 KB, patch)
2017-03-28 17:04 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2017-03-28 14:08:06 UTC
Currently we user a 'query_string' type of query for all ES searches.

ES provides a more robust query interface with boolean must/shuld/must_not options.

This patchset will pull code from bug 14567 to allow for building queries on this interface
Comment 1 Nick Clemens 2017-03-28 17:04:37 UTC
Created attachment 61664 [details] [review]
Bug 18345 - Add a more ES based query builder

This moves some code from bug 14567
Comment 2 Julian Maurice 2018-03-02 12:48:29 UTC
What is the status of this bug ? Waiting for sign-off ?
Comment 3 Nick Clemens 2018-03-02 13:47:40 UTC
Currently this is just a placeholder for some code that was lost at some point, we should pursue in the future, but i think other issues are ahead of this.

Currently we use the built in ES query parser for most things, but in the future it would be nice to leverage some of the specific ES search endpoints directly for more refined searches.

Some of that is done here: 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

Where we need to use more specific searching to mimic what we do in zebra
Comment 4 Julian Maurice 2018-03-02 13:55:10 UTC
So, it does not really block bug 14567 ?
Comment 5 Nick Clemens 2018-03-02 15:11:10 UTC
No, it shouldn't