Bug 18413 - Fix Letters.t (follow-up of 17866)
Summary: Fix Letters.t (follow-up of 17866)
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Jonathan Druart
URL:
Whiteboard:
Keywords:
Depends on: 17866
Blocks: 14723
  Show dependency treegraph
 
Reported: 2017-04-11 11:56 UTC by Marcel de Rooy
Modified: 2017-04-13 12:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18413: Fix Letters.t (following bug 17866) (1.29 KB, patch)
2017-04-11 12:18 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 18413: Fix Letters.t (following bug 17866) (1.33 KB, patch)
2017-04-11 13:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2017-04-11 11:56:41 UTC
t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576.
Comment 1 Marcel de Rooy 2017-04-11 12:18:15 UTC
Created attachment 62039 [details] [review]
Bug 18413: Fix Letters.t (following bug 17866)

SendAlert now needs a userenv to find branch email and the fallback
of KohaAdminEmailAddress if the branch mail is not filled.

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2017-04-11 12:18:58 UTC
Jonathan: please QA this one. Thanks
Comment 3 Jonathan Druart 2017-04-11 13:33:12 UTC
Created attachment 62042 [details] [review]
Bug 18413: Fix Letters.t (following bug 17866)

SendAlert now needs a userenv to find branch email and the fallback
of KohaAdminEmailAddress if the branch mail is not filled.

Test plan:
Run t/db_dependent/Letters.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Kyle M Hall 2017-04-13 12:09:33 UTC
Pushed to master for 17.05, thanks Marcel!