Bug 18528 - Patron card creator template: switch form fields for card height and card width
Summary: Patron card creator template: switch form fields for card height and card width
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-03 14:14 UTC by Marc Véron
Modified: 2017-06-20 15:15 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Confusing fields for height and width (20.57 KB, image/png)
2017-05-03 14:22 UTC, Marc Véron
Details
Bug 18528: Patron card creator template: switch form fields for card height and card width (2.12 KB, patch)
2017-05-03 14:31 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 18528: Patron card creator template: switch form fields for card height and card width (2.22 KB, patch)
2017-05-08 22:48 UTC, Alex Buckley
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2017-05-03 14:14:06 UTC
The form to create or edit a card template has a confusing sequence of fields for page and card height and width:
Page width - Page height - Card height - Card width

Switch Card height and Card width to make it more intuitive.
Comment 1 Marc Véron 2017-05-03 14:22:00 UTC
Created attachment 63014 [details]
Confusing fields for height and width
Comment 2 Marc Véron 2017-05-03 14:31:06 UTC
Created attachment 63017 [details] [review]
Bug 18528: Patron card creator template: switch form fields for card height and card width

This patch changes the sequnce of form fields for card height and card width.

To test:
- Apply patch
- Edit or create a patron card template
- Verify that the fields display in sequence Page height - Page width -Card height - Card width
Comment 3 Alex Buckley 2017-05-08 22:48:59 UTC
Created attachment 63262 [details] [review]
Bug 18528: Patron card creator template: switch form fields for card height and card width

This patch changes the sequnce of form fields for card height and card width.

To test:
- Apply patch
- Edit or create a patron card template
- Verify that the fields display in sequence Page height - Page width -Card height - Card width

Followed test plan, worked as intended
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Comment 4 Marc Véron 2017-05-18 07:13:31 UTC Comment hidden (obsolete)
Comment 5 Marc Véron 2017-06-20 15:15:11 UTC
Still applies on current master