Bug 18572 - Improper branchcode set during OPAC renewal
Summary: Improper branchcode set during OPAC renewal
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 17781
Blocks:
  Show dependency treegraph
 
Reported: 2017-05-10 15:31 UTC by Nick Clemens
Modified: 2017-06-24 20:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18572 - Improper branchcode set during OPAC renewal (3.68 KB, patch)
2017-06-23 13:21 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18572 - Improper branchcode set during OPAC renewal (3.73 KB, patch)
2017-06-24 20:14 UTC, David Kuhn
Details | Diff | Splinter Review
Bug 18572 - Improper branchcode set during OPAC renewal (3.73 KB, patch)
2017-06-24 20:30 UTC, David Kuhn
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2017-05-10 15:31:36 UTC
Bug 17781 fixed an inconsistency in renewals, but it broke functionality in the OPAC

To recreate:
1 - Set 'OpacRenewalBranch' to 'OPACrenew'
2 - Renew an item via the OPAC
3 - Check the statistics table
4 - Branch will be the user's branch, not OPACrenew
Comment 1 Nick Clemens 2017-06-23 13:21:46 UTC
Created attachment 64596 [details] [review]
Bug 18572 - Improper branchcode set during OPAC renewal

To test:
1 - Set 'OpacRenewalBranch' to various settings
2 - Renew an item for a ptron under each setting
3 - Confirm action_log entries reflect the correct branch for each
secnario
4 - prove t/db_dependent/Circulation/issue.t
Comment 2 David Kuhn 2017-06-24 20:14:54 UTC
Created attachment 64609 [details] [review]
Bug 18572 - Improper branchcode set during OPAC renewal

To test:
1 - Set 'OpacRenewalBranch' to various settings
2 - Renew an item for a ptron under each setting
3 - Confirm action_log entries reflect the correct branch for each
secnario
4 - prove t/db_dependent/Circulation/issue.t

Signed-off-by: David Kuhn <techservspec@gmail.com>
Comment 3 David Kuhn 2017-06-24 20:30:59 UTC
Created attachment 64610 [details] [review]
Bug 18572 - Improper branchcode set during OPAC renewal

To test:
1 - Set 'OpacRenewalBranch' to various settings
2 - Renew an item for a ptron under each setting
3 - Confirm action_log entries reflect the correct branch for each
secnario
4 - prove t/db_dependent/Circulation/issue.t

Step 3 in the above test should refer to entries in the statistics table as that was where the problem was originally noticed.

Signed-off-by: David Kuhn <techservspec@gmail.com>