Bug 18584 - Our legacy code contains trailing-spaces
Summary: Our legacy code contains trailing-spaces
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bugs List
QA Contact: Testopia
URL: https://github.com/joubu/koha-howto
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-11 16:45 UTC by Jonathan Druart
Modified: 2017-09-15 20:09 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18584: Fix trailing spaces in C4/Accounts.pm (894 bytes, patch)
2017-06-12 20:18 UTC, Lee Jamison
Details | Diff | Splinter Review
Bug 18584: Fix trailing spaces in C4/Accounts.pm (894 bytes, patch)
2017-06-12 20:21 UTC, Lee Jamison
Details | Diff | Splinter Review
Bug 18584: Fix trailing spaces in C4/Accounts.pm (947 bytes, patch)
2017-06-12 20:27 UTC, Lee Jamison
Details | Diff | Splinter Review
Bug 18584 - removed white space in C4/Accounts.pm (937 bytes, patch)
2017-09-12 14:41 UTC, Dominic Pichette
Details | Diff | Splinter Review
Bug 18584 - removed white space in C4/Accounts.pm (992 bytes, patch)
2017-09-12 14:47 UTC, Dominic Pichette
Details | Diff | Splinter Review
Bug 18584 - removed white space in C4/Accounts.pm (1.05 KB, patch)
2017-09-12 15:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 13208: Improving breadcrumbs for when cancelling an order (5.11 KB, patch)
2017-09-15 19:33 UTC, David Bourgault
Details | Diff | Splinter Review
Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules (3.89 KB, patch)
2017-09-15 19:33 UTC, David Bourgault
Details | Diff | Splinter Review
Bug 13208: [FOLLOW-UP] Perl documentation for modules (3.61 KB, patch)
2017-09-15 19:33 UTC, David Bourgault
Details | Diff | Splinter Review
Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion (1.78 KB, patch)
2017-09-15 19:33 UTC, David Bourgault
Details | Diff | Splinter Review
Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets (2.97 KB, patch)
2017-09-15 19:33 UTC, David Bourgault
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2017-05-11 16:45:56 UTC
This bug report is opened for didactic purpose.

If you already contributed to Koha you must not contribute here.
Comment 1 Lee Jamison 2017-06-12 20:18:34 UTC Comment hidden (obsolete)
Comment 2 Lee Jamison 2017-06-12 20:21:42 UTC Comment hidden (obsolete)
Comment 3 Lee Jamison 2017-06-12 20:27:41 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2017-06-12 20:59:39 UTC
(In reply to Lee Jamison from comment #3)
> Created attachment 64238 [details] [review] [review]
> Bug 18584: Fix trailing spaces in C4/Accounts.pm

Pushed to master, thanks Lee!
Resetting to New.
Comment 5 Katrin Fischer 2017-06-13 20:59:16 UTC
... and pushed to 2 stable releases (16.11 and 17.05) - congrats Lee!
Comment 6 Mason James 2017-07-31 11:23:47 UTC
Pushed to 16.05.x, for 16.05.15 release
Comment 7 Dominic Pichette 2017-09-12 14:41:29 UTC
Created attachment 67095 [details] [review]
Bug 18584 - removed white space in C4/Accounts.pm

Test Plan:
    1-go to C4/Accounts.pm
    2-there should not be a trailing space at line 279.
Comment 8 Dominic Pichette 2017-09-12 14:47:01 UTC
Created attachment 67096 [details] [review]
Bug 18584 - removed white space in C4/Accounts.pm

Test Plan:
    1-go to C4/Accounts.pm
    2-there should not be a trailing space at line 279.

Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Comment 9 Jonathan Druart 2017-09-12 15:02:53 UTC
Created attachment 67097 [details] [review]
Bug 18584 - removed white space in C4/Accounts.pm

Test Plan:
    1-go to C4/Accounts.pm
    2-there should not be a trailing space at line 279.

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2017-09-12 15:10:08 UTC
(In reply to Dominic Pichette from comment #7)
> Created attachment 67095 [details] [review] [review]
> Bug 18584 - removed white space in C4/Accounts.pm
> 
> Test Plan:
>     1-go to C4/Accounts.pm
>     2-there should not be a trailing space at line 279.

Pushed to master, Merci Dominic!
Resetting to New.
Comment 11 David Bourgault 2017-09-15 19:33:10 UTC Comment hidden (obsolete)
Comment 12 David Bourgault 2017-09-15 19:33:13 UTC Comment hidden (obsolete)
Comment 13 David Bourgault 2017-09-15 19:33:16 UTC Comment hidden (obsolete)
Comment 14 David Bourgault 2017-09-15 19:33:19 UTC Comment hidden (obsolete)
Comment 15 David Bourgault 2017-09-15 19:33:22 UTC Comment hidden (obsolete)
Comment 16 David Bourgault 2017-09-15 20:09:32 UTC Comment hidden (obsolete)