Bug 18589 - Show ILLs as part of patron profile
Summary: Show ILLs as part of patron profile
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Andrew Isherwood
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 20563 21460
Blocks: 19605
  Show dependency treegraph
 
Reported: 2017-05-12 10:57 UTC by Magnus Enger
Modified: 2018-12-05 10:48 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18589: Show ILLs as part of patron profile (26.87 KB, patch)
2018-04-24 13:39 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 18589: Show ILLs as part of patron profile (26.98 KB, patch)
2018-10-01 07:54 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 18589: Show ILLs as part of patron profile (53.42 KB, patch)
2018-11-09 15:55 UTC, Andrew Isherwood
Details | Diff | Splinter Review
Bug 18589: Show ILLs as part of patron profile (53.77 KB, patch)
2018-11-19 15:14 UTC, Andrew Isherwood
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2017-05-12 10:57:11 UTC
Bug 7317 adds a "Interlibrary loans" tab on the left hand side of patron details, under Purchase suggestions. But this behaves more like a link than a tab, taking you to the ILL module and a list limited to the patron in question. It would be better if this view looked more like a part of the patron details, with the tabs on the left hand side and the buttons on top. 

Compare this to the "Modification log" tab/link, which actually takes you to the log "module", but still looks like part of the patron profile.
Comment 1 Andrew Isherwood 2018-04-24 13:39:20 UTC
Created attachment 74809 [details] [review]
Bug 18589: Show ILLs as part of patron profile

This patch moves the display of a patron's ILL requests to be inline in
the Patron Profile page, as per all other patron information.

It includes a substantial refactor of
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it
moves the display of the illlist table (which is populated by an API
request) into it's own separate include file. It also moves the
datatable related Javascript for this table into it's own JS file. Doing
this allows us to reuse both in both the new members/ill-requests.tt
template and the pre-existing ill/ill-requests.tt template.

To test:
1) Ensure ILL is enabled and your user has sufficient permissions
2) Ensure your user has some ILL requests
3) Navigate to the user's patron profile page
4) Click on the "Interlibrary loans" tab
5) Observe that the requests table is displayed inline
6) Observe that only your user's requests are displayed
Comment 2 Andrew Isherwood 2018-04-24 13:43:26 UTC
Dependencies have been added to reflect other pending patches that touch ill-requests.tt, which has been substantially refactored here
Comment 3 Andrew Isherwood 2018-09-27 13:44:24 UTC
Dependencies updated
Comment 4 PTFS Europe Sandboxes 2018-10-01 07:54:22 UTC
Created attachment 79692 [details] [review]
Bug 18589: Show ILLs as part of patron profile

This patch moves the display of a patron's ILL requests to be inline in
the Patron Profile page, as per all other patron information.

It includes a substantial refactor of
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it
moves the display of the illlist table (which is populated by an API
request) into it's own separate include file. It also moves the
datatable related Javascript for this table into it's own JS file. Doing
this allows us to reuse both in both the new members/ill-requests.tt
template and the pre-existing ill/ill-requests.tt template.

To test:
1) Ensure ILL is enabled and your user has sufficient permissions
2) Ensure your user has some ILL requests
3) Navigate to the user's patron profile page
4) Click on the "Interlibrary loans" tab
5) Observe that the requests table is displayed inline
6) Observe that only your user's requests are displayed

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie
Comment 5 Andrew Isherwood 2018-11-09 15:55:00 UTC
Comment on attachment 79692 [details] [review]
Bug 18589: Show ILLs as part of patron profile

Obsoleted by rebase upon current dependency tree
Comment 6 Andrew Isherwood 2018-11-09 15:55:21 UTC
Created attachment 82177 [details] [review]
Bug 18589: Show ILLs as part of patron profile

This patch moves the display of a patron's ILL requests to be inline in
the Patron Profile page, as per all other patron information.

It includes a substantial refactor of
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it
moves the display of the illlist table (which is populated by an API
request) into it's own separate include file. It also moves the
datatable related Javascript for this table into it's own JS file. Doing
this allows us to reuse both in both the new members/ill-requests.tt
template and the pre-existing ill/ill-requests.tt template.

To test:
1) Ensure ILL is enabled and your user has sufficient permissions
2) Ensure your user has some ILL requests
3) Navigate to the user's patron profile page
4) Click on the "Interlibrary loans" tab
5) Observe that the requests table is displayed inline
6) Observe that only your user's requests are displayed

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie
Comment 7 Andrew Isherwood 2018-11-19 15:14:51 UTC
Created attachment 82513 [details] [review]
Bug 18589: Show ILLs as part of patron profile

This patch moves the display of a patron's ILL requests to be inline in
the Patron Profile page, as per all other patron information.

It includes a substantial refactor of
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it
moves the display of the illlist table (which is populated by an API
request) into it's own separate include file. It also moves the
datatable related Javascript for this table into it's own JS file. Doing
this allows us to reuse both in both the new members/ill-requests.tt
template and the pre-existing ill/ill-requests.tt template.

To test:
1) Ensure ILL is enabled and your user has sufficient permissions
2) Ensure your user has some ILL requests
3) Navigate to the user's patron profile page
4) Click on the "Interlibrary loans" tab
5) Observe that the requests table is displayed inline
6) Observe that only your user's requests are displayed

Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie