Bug 18638 - Bad display of prediction pattern with planified irregularities : translation issue
Summary: Bad display of prediction pattern with planified irregularities : translation...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 3.22
Hardware: All All
: P3 normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-19 12:18 UTC by Koha Team University Lyon 3
Modified: 2020-11-30 21:45 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Team University Lyon 3 2017-05-19 12:18:20 UTC
The problem occurs in french interface.
Due to nested double quotes in French translation of a javascript message, the message is broken, both pages of prediction pattern are displayed at the same time and it's not possible to modify anything.

=============================
In the po file we have this :
#. SCRIPT
#: intranet-tmpl/prog/en/modules/serials/subscription-add.tt:13
msgid ""
"Warning! Present pattern has planned irregularities. Click on 'Test "
"prediction pattern' to check if it's still valid"
msgstr ""
"Attention ! Le modèle présent a planifié des irrégularités.Cliquez sur "
"\"Tester le prévisionnel de bulletinage\" pour vérifier s'il est toujours "
"valable"
==============================
In susbscription-add.tt we have :
English
   alert(_("Warning! Present pattern has planned irregularities. Click on 'Test prediction pattern' to check if it's still valid"));
French
   alert(_("Attention ! Le modèle présent a planifié des irrégularités.Cliquez sur "Tester le prévisionnel de bulletinage" pour vérifier s'il est toujours valable"));

I suppose the double quotes are automatically escaped through po file creation but to get a correct rendering double quotes should be escaped by a double backslash.
Comment 1 Katrin Fischer 2020-04-19 11:27:27 UTC
I've checked the current French translations for this string and it appears to have been fixed:

# Do not change single or double quotes it may brake JavaScript
#. SCRIPT
#: intranet-tmpl/prog/en/modules/serials/subscription-add.tt:519
msgid ""
"Warning! Present pattern has planned irregularities. Click on 'Test "
"prediction pattern' to check if it's still valid"
msgstr ""
"Attention ! Il y a des irrégularités dans le présent modèle. Cliquez "
"sur « Tester le prévisionnel de bulletinage » pour vérifier s'il "
"est toujours valable"

Note: translation issues like this need to be resolved on translate.koha-community.org by fixing the translation.