Bug 18657 - Inventory tool should display more statuses/problems
Summary: Inventory tool should display more statuses/problems
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Galen Charlton
QA Contact: Lisette Scheer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-23 12:32 UTC by Nick Clemens (kidclamp)
Modified: 2025-01-16 16:41 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds two new checkboxes to the inventory tool. One will show lost items and the other will show items without a problem when barcodes aren't compared.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 18657: Add the possibility to add lost items to the report (5.13 KB, patch)
2024-07-18 14:54 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 18657: Add the possibility to add every items to the report (3.24 KB, patch)
2024-07-18 14:54 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 18657: Add the possibility to add lost items to the report (4.94 KB, patch)
2024-07-18 15:01 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 18657: Add the possibility to add every items to the report (3.24 KB, patch)
2024-07-18 15:01 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 18657: Add the possibility to add lost items to the report (5.01 KB, patch)
2024-08-02 17:48 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 18657: Add the possibility to add every items to the report (3.30 KB, patch)
2024-08-02 17:48 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 18657: Add the possibility to add lost items to the report (5.07 KB, patch)
2024-12-30 19:01 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 18657: Add the possibility to add lost items to the report (5.07 KB, patch)
2024-12-30 19:01 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 18657: Add the possibility to add every items to the report (3.37 KB, patch)
2024-12-30 19:03 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2017-05-23 12:32:14 UTC
Currently the tool reports:
Incorrect not-for-loan values
Wrong place
Checked out

We should have:
Optional display of items w/o problems
Display of missing/lost items now marked found
Comment 1 Tom Misilo 2017-05-23 13:05:33 UTC
Is it possible #12913 removed some of the existing functionality? Like "Display of missing/lost items now marked found"
Comment 2 Marcel de Rooy 2017-05-23 13:29:44 UTC
(In reply to Tom Misilo from comment #1)
> Is it possible #12913 removed some of the existing functionality? Like
> "Display of missing/lost items now marked found"

Functionality was not the right word for the status of the code ;)
Comment 3 Baptiste Wojtkowski (bwoj) 2024-07-18 14:54:50 UTC Comment hidden (obsolete)
Comment 4 Baptiste Wojtkowski (bwoj) 2024-07-18 14:54:53 UTC Comment hidden (obsolete)
Comment 5 Baptiste Wojtkowski (bwoj) 2024-07-18 15:01:32 UTC
Created attachment 169143 [details] [review]
Bug 18657: Add the possibility to add lost items to the report

Currently the tool reports:
Incorrect not-for-loan values
Wrong place
Checked out

We should have:
Optional display of items w/o problems
Display of missing/lost items now marked found

TEST PLAN
1 - Mark an item as lost
2 - Go to tools->inventory
3 - Fill in the barcode list with the barcode of the item, notice there
  is one checkbox in "Additional options"
4 - Submit -> there should be no result
5 - Apply patches and redo 1,2&3
6 - Notice there are now 3 checkboxes in "Additional options"
7 - Click on "Add lost items to the report"
8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found"
9 - Go to tools->inventory
10 - Click on "Add lost items to the report"
11 - Submit -> there is no line in the report
12 - Go to tools->inventory
13 - Click on "Add items without problem to the report"
11 - Submit -> there is now line in the report with an empty problem
Comment 6 Baptiste Wojtkowski (bwoj) 2024-07-18 15:01:35 UTC
Created attachment 169144 [details] [review]
Bug 18657: Add the possibility to add every items to the report

Currently the tool reports:
Incorrect not-for-loan values
Wrong place
Checked out

We should have:
Optional display of items w/o problems
Display of missing/lost items now marked found

TEST PLAN
1 - Mark an item as lost
2 - Go to tools->inventory
3 - Fill in the barcode list with the barcode of the item, notice there
  is one checkbox in "Additional options"
4 - Submit -> there should be no result
5 - Apply patches and redo 1,2&3
6 - Notice there are now 3 checkboxes in "Additional options"
7 - Click on "Add lost items to the report"
8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found"
9 - Go to tools->inventory
10 - Click on "Add lost items to the report"
11 - Submit -> there is no line in the report
12 - Go to tools->inventory
13 - Click on "Add items without problem to the report"
11 - Submit -> there is now line in the report with an empty problem
Comment 7 Mathieu Saby 2024-08-02 17:48:01 UTC
I tested on a sandbox. The two new options work as described, I sign off.

I wonder if we should not also add a message in a yellow alert box if the item had a lost status, and if the option "Add losts items to the report" is checked? Not sure of that...
Comment 8 Biblibre Sandboxes 2024-08-02 17:48:45 UTC
Created attachment 170012 [details] [review]
Bug 18657: Add the possibility to add lost items to the report

Currently the tool reports:
Incorrect not-for-loan values
Wrong place
Checked out

We should have:
Optional display of items w/o problems
Display of missing/lost items now marked found

TEST PLAN
1 - Mark an item as lost
2 - Go to tools->inventory
3 - Fill in the barcode list with the barcode of the item, notice there
  is one checkbox in "Additional options"
4 - Submit -> there should be no result
5 - Apply patches and redo 1,2&3
6 - Notice there are now 3 checkboxes in "Additional options"
7 - Click on "Add lost items to the report"
8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found"
9 - Go to tools->inventory
10 - Click on "Add lost items to the report"
11 - Submit -> there is no line in the report
12 - Go to tools->inventory
13 - Click on "Add items without problem to the report"
11 - Submit -> there is now line in the report with an empty problem

Signed-off-by: Mathieu Saby <mathsabypro@gmail.com>
Comment 9 Biblibre Sandboxes 2024-08-02 17:48:47 UTC
Created attachment 170013 [details] [review]
Bug 18657: Add the possibility to add every items to the report

Currently the tool reports:
Incorrect not-for-loan values
Wrong place
Checked out

We should have:
Optional display of items w/o problems
Display of missing/lost items now marked found

TEST PLAN
1 - Mark an item as lost
2 - Go to tools->inventory
3 - Fill in the barcode list with the barcode of the item, notice there
  is one checkbox in "Additional options"
4 - Submit -> there should be no result
5 - Apply patches and redo 1,2&3
6 - Notice there are now 3 checkboxes in "Additional options"
7 - Click on "Add lost items to the report"
8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found"
9 - Go to tools->inventory
10 - Click on "Add lost items to the report"
11 - Submit -> there is no line in the report
12 - Go to tools->inventory
13 - Click on "Add items without problem to the report"
11 - Submit -> there is now line in the report with an empty problem

Signed-off-by: Mathieu Saby <mathsabypro@gmail.com>
Comment 10 Lisette Scheer 2024-12-30 19:01:10 UTC
Created attachment 176017 [details] [review]
Bug 18657: Add the possibility to add lost items to the report

Works great and passes tests!
I updated the test plan to reflect the location of inventory.
Currently the tool reports:
Incorrect not-for-loan values
Wrong place
Checked out

We should have:
Optional display of items w/o problems
Display of missing/lost items now marked found

TEST PLAN
1 - Mark an item as lost
2 - Go to cataloging->inventory
3 - Fill in the barcode list with the barcode of the item, notice there
  is one checkbox in "Additional options"
4 - Submit -> there should be no result
5 - Apply patches and redo 1,2&3
6 - Notice there are now 3 checkboxes in "Additional options"
7 - Click on "Add lost items to the report"
8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found"
9 - Go to cataloging->inventory
10 - Click on "Add lost items to the report"
11 - Submit -> there is no line in the report
12 - Go to cataloging->inventory
13 - Click on "Add items without problem to the report"
11 - Submit -> there is now line in the report with an empty problem

Signed-off-by: Mathieu Saby <mathsabypro@gmail.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 11 Lisette Scheer 2024-12-30 19:01:49 UTC
Created attachment 176018 [details] [review]
Bug 18657: Add the possibility to add lost items to the report

Currently the tool reports:
Incorrect not-for-loan values
Wrong place
Checked out

We should have:
Optional display of items w/o problems
Display of missing/lost items now marked found

TEST PLAN
1 - Mark an item as lost
2 - Go to tools->inventory
3 - Fill in the barcode list with the barcode of the item, notice there
  is one checkbox in "Additional options"
4 - Submit -> there should be no result
5 - Apply patches and redo 1,2&3
6 - Notice there are now 3 checkboxes in "Additional options"
7 - Click on "Add lost items to the report"
8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found"
9 - Go to tools->inventory
10 - Click on "Add lost items to the report"
11 - Submit -> there is no line in the report
12 - Go to tools->inventory
13 - Click on "Add items without problem to the report"
11 - Submit -> there is now line in the report with an empty problem

Signed-off-by: Mathieu Saby <mathsabypro@gmail.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 12 Lisette Scheer 2024-12-30 19:03:14 UTC
Created attachment 176019 [details] [review]
Bug 18657: Add the possibility to add every items to the report

Currently the tool reports:
Incorrect not-for-loan values
Wrong place
Checked out

We should have:
Optional display of items w/o problems
Display of missing/lost items now marked found

TEST PLAN
1 - Mark an item as lost
2 - Go to cataloging->inventory
3 - Fill in the barcode list with the barcode of the item, notice there
  is one checkbox in "Additional options"
4 - Submit -> there should be no result
5 - Apply patches and redo 1,2&3
6 - Notice there are now 3 checkboxes in "Additional options"
7 - Click on "Add lost items to the report"
8 - Submit -> there is now one line in the report with problem "Item was lost and is now marked as found"
9 - Go to cataloging->inventory
10 - Click on "Add lost items to the report"
11 - Submit -> there is no line in the report
12 - Go to cataloging->inventory
13 - Click on "Add items without problem to the report"
11 - Submit -> there is now line in the report with an empty problem

Signed-off-by: Mathieu Saby <mathsabypro@gmail.com>
Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 13 Katrin Fischer 2025-01-16 15:59:22 UTC
Fixed inline:

<label for="ReportLostItems">Add losts items to the report: </label>
-> Add lost items
Comment 14 Katrin Fischer 2025-01-16 16:41:42 UTC
Pushed for 25.05!

Well done everyone, thank you!