Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive.
Created attachment 63745 [details] [review] Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools
Created attachment 63774 [details] [review] Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools Followed test plan and everything was as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 63837 [details] [review] Bug 18681 - (followup) Remove on more [%% in translation for about.tt Test plan same as in previous patch Run QA tools in newest version (test for line breaks in tt directives)
Set back to NSO for the followup
Created attachment 63994 [details] [review] Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools Followed test plan and everything was as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 63995 [details] [review] Bug 18681: Translatability: Get rid of [%% in translation for about.tt Translation tool picks a line %s [%% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || ...due to a line break inside a template directive. This patch fixes it. To test: - Update QA tools (see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18675#c2) - Verify that code change makes sense - Apply patch - Run QA tools Followed test plan and everything was as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 63996 [details] [review] Bug 18681 - (followup) Remove on more [%% in translation for about.tt Test plan same as in previous patch Run QA tools in newest version (test for line breaks in tt directives) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Trivial, skipping QA.
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01