Bug 18721 - C4::Installer uses Koha::Database instead
Summary: C4::Installer uses Koha::Database instead
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 11974
  Show dependency tree / graph
 
Reported: 2017-06-02 09:40 UTC by Olli-Antti Kivilahti
Modified: 2017-10-23 15:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 18721 - C4::Installer uses Koha::Database instead (2.06 KB, patch)
2017-06-02 09:41 UTC, Olli-Antti Kivilahti 		Details | Diff | Splinter Review
Bug 18721: (follow-up) Restore dbms attribute in class, fix Installer.t (2.32 KB, patch)
2017-06-19 11:34 UTC, Lari Taskula 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2017-06-02 09:40:40 UTC 
C4::Installer->new()
duplicates code from Koha::Database->_new_schema()

Fixing by making C4::Installer get the db connection the normal way.

TEST PLAN:

use misc/devel/populate_db.pl
or  installer/install_automatic.pl

whichever you have

to deploy the default database.
Comment 1 Olli-Antti Kivilahti 2017-06-02 09:41:55 UTC 
Created attachment 63933 [details] [review]
Bug 18721 - C4::Installer uses Koha::Database instead
Comment 2 Josef Moravec 2017-06-06 04:42:11 UTC 
I used populate_db.pl, but does not work - the database tables were not created.
Comment 3 Lari Taskula 2017-06-19 11:34:54 UTC 
Created attachment 64423 [details] [review]
Bug 18721: (follow-up) Restore dbms attribute in class, fix Installer.t

This patch restores "dbms" attribute in C4::Installer, since it is used in
the class. I also checked if other scripts and modules are using any of the class
attributes, but did not notice further issues, apart from Installer.t

Removes now unneeded tests from t/db_dependent/Installer.t.

To test:
1. prove t/db_dependent/Installer.t