Bug 18742 - Circulation statistics wizard no longer exports the total row
Summary: Circulation statistics wizard no longer exports the total row
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Whiteboard:
Keywords: Academy
Depends on: 7679
Blocks:
  Show dependency treegraph
 
Reported: 2017-06-07 14:56 UTC by Nick Clemens
Modified: 2017-08-12 18:59 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18742 - Circulation statistics wizard no longer exports the total row (951 bytes, patch)
2017-06-07 14:58 UTC, Nick Clemens
Details | Diff | Splinter Review
[SIGNED OFF] Bug 18742 - Circulation statistics wizard no longer exports the total row (1.00 KB, patch)
2017-08-12 18:59 UTC, Christopher Brannon
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2017-06-07 14:56:23 UTC
It seems like a few lines were lost from issues-stats.pl in bug 7679:

# footer
        print "TOTAL";
        $cols = @$results[0]->{loopfooter};
               print map {$sep.$_->{totalcol}} @$cols;
        print $sep.@$results[0]->{total};
Comment 1 Nick Clemens 2017-06-07 14:58:14 UTC
Created attachment 64081 [details] [review]
Bug 18742 - Circulation statistics wizard no longer exports the total row

To test:
Run the circulation wizard
Export to csv
Note there is no total row
Apply patch
Export to csv
Total row totally there!
Comment 2 Jonathan Druart 2017-07-26 17:46:45 UTC
Regarding bug 7679 this line was wrong, that is why it has been removed.
Comment 3 Christopher Brannon 2017-08-12 18:59:48 UTC
Created attachment 65938 [details] [review]
[SIGNED OFF] Bug 18742 - Circulation statistics wizard no longer exports the total row

To test:
Run the circulation wizard
Export to csv
Note there is no total row
Apply patch
Export to csv
Total row totally there!

Works as expected.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>


:call TrimWhiteSpace()