Unit Test command 'prove -v xt/author/Text_CSV_Various.t' fails even with prerequisite modules installed According to the Koha Wiki signoff documentation, in order for 'prove xt/' to pass, the following modules must be installed: Test::Pod; Test::Pod::Spelling Text::CSV::Unicode however, even with these modules installed, running the prove command on Text_CSV_Various.t exits with the following outputs: not ok 10 - parse (Text::CSV) not ok 13 - parse (Text::CSV::Unicode) not ok 16 - parse (Text::CSV_XS) not ok 19 - parse (Text::CSV) not ok 22 - parse (Text::CSV::Unicode) not ok 25 - parse (Text::CSV_XS) ok 26 - parse (Text::CSV_XS (binary)) ok 27 - Number of fields (6 of 6) field 1: field1 field 2: second field field 3: field3 field 4: do_we_have_a_e_problem? (the _e_ appears to have a dot over it which appears - after researching - to be the 9th letter of the Lithuanian alphabet) field 5: f!fth field field 6: lastfield # For each of the above "not ok" and "ok" failures, it prints the following message: Failed test 'parse (Module::Name)' at xt/author/Text_CSV_Various.t line 57. Wide character in print at xt/author/Text_CSV_Various.t line 63.
It seems that the failures are expected. I'd suggest to remove this file.
Created attachment 64091 [details] [review] Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used.
Let's give it a try!
Created attachment 64110 [details] [review] Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Running 'prove xt/author/Text_CSV_Various.t' passes
Created attachment 64130 [details] [review] Bug 18746: Text_CSV_Various parse failures While it might be an idea to just delete it, this patch attempts to catch everything and make it clear that Text::CSV::Unicode (binary) is the parser that should be used. Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Running 'prove xt/author/Text_CSV_Various.t' passes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 64131 [details] [review] Bug 18746: Add license and remove diag Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01
This patch has been pushed to 16.11.x and will be in 16.11.09.
Pushed to 16.05.x, for 16.05.15 release