# Failed test 'Columns are missing for patron: lang, overdrive_auth_token, login_attempts'
Created attachment 64118 [details] [review] Bug 18763: Fix swagger/definitions.t tests Test plan: prove api/v1/swagger/definitions/patron.json must return green
Created attachment 64119 [details] [review] [SIGNED OFF] Bug 18763: Fix swagger/definitions.t Test plan: prove api/v1/swagger/definitions/patron.json must return green Signed-off-by: Lee Jamison <ldjamison@marywood.edu> swagger/definitions.t test returns green
For what it's worth, I git bz'd 18508 and then 18763. I had to tweak the git bz, but basically both combined fix noise and test failures.
Skipping QA.
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.01 Test plan says : prove api/v1/swagger/definitions/patron.json It is : prove t/db_dependent/api/v1/swagger/definitions.t
Test fails for me locally, but columns listed are not in 16.11.x - please provide a separate patch for this version if it's needed.
Test Summary Report ------------------- api/v1/swagger/definitions/patron.json (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: No plan found in TAP output Files=1, Tests=0, 0 wallclock secs ( 0.01 usr + 0.01 sys = 0.02 CPU) Result: FAIL kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove api/v1/swagger/definitions/patron.json api/v1/swagger/definitions/patron.json .. syntax error at api/v1/swagger/definitions/patron.json line 2, near ""type":" Execution of api/v1/swagger/definitions/patron.json aborted due to compilation errors. api/v1/swagger/definitions/patron.json .. Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run
Won't apply to 16.11.x as is, closing!