Bug 18765 - Bad cardnumber causes 'Borrower' search to fail
Summary: Bad cardnumber causes 'Borrower' search to fail
Status: RESOLVED DUPLICATE of bug 22781
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-09 06:17 UTC by Mason James
Modified: 2019-11-21 10:50 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
pic (97.11 KB, image/png)
2017-06-09 06:17 UTC, Mason James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2017-06-09 06:17:34 UTC
Created attachment 64122 [details]
pic

to test bug..
1/ add a leading TAB character to a borrower's cardnumber

2/ attempt to search for that user

3/ observe that no results are displayed  (see pic)
Comment 1 Lee Jamison 2017-06-09 13:51:35 UTC
Hi Mason,

can you provide clarification for your step 1? I'm confused what you mean by a leading tab character because pressing the TAB key in the cardnumber field of memberentry.pl?op=modify simply changes the focus to the Library drop down field. Are you referring to the escaped '\t' character?
Comment 2 Mason James 2017-06-15 11:48:49 UTC
> ...because pressing the TAB key in the cardnumber field
> of memberentry.pl?op=modify simply changes the focus to the Library drop
> down field.

I copy/pasted the problematic string from a text-editor into the field
Comment 3 Jonathan Druart 2017-09-27 17:59:24 UTC
We can do that:

+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt
@@ -14,7 +14,7 @@
                     "<input type='checkbox' class='selection' name='borrowernumber' value='[% data.borrowernumber %]' />",
                 [% END %]
                 "dt_cardnumber":
-                    "[% data.cardnumber | html %]",
+                    "[% To.json( data.cardnumber ) %]",


But we should do it for all the data.
Comment 4 Owen Leonard 2019-11-20 18:32:47 UTC
I'm not able to save a card number with a tab character, so I think this can be considered fixed.
Comment 5 Jonathan Druart 2019-11-21 10:50:55 UTC

*** This bug has been marked as a duplicate of bug 22781 ***