Created attachment 64196 [details] [review] Bug 18784: Add 'auto claim' option to subscription batch edit tool
For test plan see bug 18426
Blocked by depending patches in Failed QA :(
Patch is missing a closing HTML tag </li>
Created attachment 91429 [details] [review] Bug 18784: Add 'auto claim' option to subscription batch edit tool
Patch rebased on master + added the missing closing HTML tag
Created attachment 124985 [details] [review] Bug 18784: Add 'auto claim' option to subscription batch edit tool
Patch rebased on master
I tested this on PTFS Europe's sandbox and got the following error when I changed in batch edit Enable automatic claims -> Yes. The method Koha::Subscription->auto_claim_enabled is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 931 Koha::Object::AUTOLOAD('Koha::Subscription=HASH(0x561f2228ef70)', 1) called at /kohadevbox/koha/serials/subscription-batchedit.pl line 75 eval {...} at /kohadevbox/koha/serials/subscription-batchedit.pl line 2 CGI::Compile::ROOT::kohadevbox_koha_serials_subscription_2dbatchedit_2epl::__ANON__('CGI::Compile=HASH(0x561f212bfe10)', '', '/kohadevbox/koha/serials/subscription-batchedit.pl', '/kohadevbox/koha/serials', 'ARRAY(0x561f215d3778)') called at /usr/share/perl5/CGI/Compile.pm line 151 CGI::Compile::ROOT::kohadevbox_koha_serials_subscription_2dbatchedit_2epl::subscription_2dbatchedit_2epl at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 CGI::Emulate::PSGI::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x561f2188aa88)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x561f173e7a30)', 'HASH(0x561f21f35db8)', '/kohadevbox/koha/serials/subscription-batchedit.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x561f173e7a30)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/LogWarn.pm line 22 Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x561f212ef248)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Log4perl.pm line 30 Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x561f212f6f58)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 20 Plack::Middleware::HTTPExceptions::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x561f2161c7c8)', 'Try::Tiny::Catch=REF(0x561f21ff9598)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 23 Plack::Middleware::HTTPExceptions::call('Plack::Middleware::HTTPExceptions=HASH(0x561f212f69d0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/ErrorDocument.pm line 15 Plack::Middleware::ErrorDocument::call('Plack::Middleware::ErrorDocument=HASH(0x561f21515c98)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x561f200e95f8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /kohadevbox/koha/Koha/Middleware/RealIP.pm line 64 Koha::Middleware::RealIP::call('Koha::Middleware::RealIP=HASH(0x561f212f6da8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /kohadevbox/koha/Koha/Middleware/SetEnv.pm line 106 Koha::Middleware::SetEnv::call('Koha::Middleware::SetEnv=HASH(0x561f21407f80)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Static.pm line 18 Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x561f21515b78)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68 Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x561f21515ed8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/Lint.pm line 24 Plack::Middleware::Lint::call('Plack::Middleware::Lint=HASH(0x561f173e77f0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 38 Plack::Middleware::StackTrace::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 eval {...} at /usr/share/perl5/Try/Tiny.pm line 93 Try::Tiny::try('CODE(0x561f21d32aa8)', 'Try::Tiny::Catch=REF(0x561f221c52c0)') called at /usr/share/perl5/Plack/Middleware/StackTrace.pm line 42 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x561f200de578)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 27 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x561f200dd7c8)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x561f21f35db8)') called at /usr/share/perl5/Plack/Util.pm line 145 eval {...} at /usr/share/perl5/Plack/Util.pm line 145 Plack::Util::run_app('CODE(0x561f200dd708)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Starman/Server.pm line 195 Starman::Server::dispatch_request('Starman::Server=HASH(0x561f16e053b0)', 'HASH(0x561f21f35db8)') called at /usr/share/perl5/Starman/Server.pm line 298 Starman::Server::process_request('Starman::Server=HASH(0x561f16e053b0)', 'Net::Server::Proto::UNIX=GLOB(0x561f21a137c8)') called at /usr/share/perl5/Net/Server.pm line 72 Net::Server::run_client_connection('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server/PreFork.pm line 225 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 225 Net::Server::PreFork::run_child('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server/PreFork.pm line 183 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0x561f16e053b0)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 107 Net::Server::PreFork::loop('Starman::Server=HASH(0x561f16e053b0)') called at /usr/share/perl5/Net/Server.pm line 58 Net::Server::run('Starman::Server=HASH(0x561f16e053b0)', 'port', 'ARRAY(0x561f17392100)', 'host', '*', 'proto', 'tcp', 'serialize', 'none', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_requests', 50, 'user', 'bug18784-koha', 'group', 'bug18784-koha', 'listen', 1024, 'check_for_waiting', 1, 'no_client_stdout', 1, 'pid_file', '/var/run/koha/bug18784/plack.pid', 'setsid', 1, 'log_file', '/var/log/koha/bug18784/plack-error.log', 'background', 1) called at /usr/share/perl5/Starman/Server.pm line 106 Starman::Server::run('Starman::Server=HASH(0x561f16e053b0)', 'CODE(0x561f16e05260)', 'HASH(0x561f16e05008)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 25 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x561f16e05278)', 'CODE(0x561f16e05260)') called at /usr/share/perl5/Plack/Loader/Delayed.pm line 20 Plack::Loader::Delayed::run('Plack::Loader::Delayed=HASH(0x561f16b56f10)', 'Plack::Handler::Starman=HASH(0x561f16e05278)') called at /usr/share/perl5/Plack/Runner.pm line 279 Plack::Runner::run('Plack::Runner=HASH(0x561f16af0360)') called at /usr/bin/starman line 38 at /usr/share/perl5/Exception/Class/Base.pm line 88 I tried to refresh the schema and restart the services but there was no change. Any tips how to test this further?
Created attachment 155464 [details] [review] Bug 18784: (QA follow-up) Tidy code block Tidy the affected code block around changed line from this patchset to allow perltidy QA check to pass.
Created attachment 155465 [details] [review] Bug 18784: Add 'auto claim' option to subscription batch edit tool Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 155466 [details] [review] Bug 18784: (QA follow-up) Tidy code block Tidy the affected code block around changed line from this patchset to allow perltidy QA check to pass.
I've added the missing DBIC files to the dependency bug added a follow-up here to get it passing the QA scripts. Be great to have some testing on this pair now the sandboxes should be available to test this one at least (for the dependency, you'll need to ask for some help to enable the new cronjob)