When merging two authorities and deciding the framework to sue the default is a 'Default' with value 'Default' The issue is that the Default framework actually has code '' - this is picked up in the generated list so we can just remove the line (if this is unclear the patch should be clear)
Created attachment 64282 [details] [review] Bug 18801 - Merging authorities has an invalid 'Default' type in the merge framework selector To test: 1 - Find two authorities and start a merge 2 - Leave the dropdown at 'Default' 3 - Merge records and note you get an error and can no longer view the new record 4 - Check DB value of record authtypecode = 'Default' 5 - Apply patch 6 - Find two other authorities 7 - Merge leaving selector at default 8 - Success 9 - Check DB value of record authtypecode = ''
Please have a look at bug 17380. It was still pending on my list.
Created attachment 64303 [details] [review] Bug 18801 - Merging authorities has an invalid 'Default' type in the merge framework selector To test: 1 - Find two authorities and start a merge 2 - Leave the dropdown at 'Default' 3 - Merge records and note you get an error and can no longer view the new record 4 - Check DB value of record authtypecode = 'Default' 5 - Apply patch 6 - Find two other authorities 7 - Merge leaving selector at default 8 - Success 9 - Check DB value of record authtypecode = '' Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 64325 [details] [review] Bug 18801: [Follow-up] Dbrev to repair bad auth type codes Test plan Run updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Taking the liberty to move this trivial patch to PQA
DBRev would have been better with SELECT COUNT(*) FROM auth_types WHERE authtypecode = "Default" But not blocker.
Pushed to master for 17.11, thanks to everybody involved!
(In reply to Jonathan Druart from comment #6) > DBRev would have been better with > SELECT COUNT(*) FROM auth_types WHERE authtypecode = "Default" > But not blocker. Yes indeed.
Waiting for Bug 17380 to integrate in stable branch
Pushed to 17.05.x, will be in 17.05.06.
These patches have been pushed to 16.11.x and will be in 16.11.14.
Pushed to 16.05.x, for 16.05.19 release