Bug 18812 - SIP Patron status does not respect OverduesBlockCirc
Summary: SIP Patron status does not respect OverduesBlockCirc
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-15 15:05 UTC by Nick Clemens
Modified: 2017-06-17 14:20 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18812 - SIP Patron status does not respect OverduesBlockCirc (4.32 KB, patch)
2017-06-15 15:11 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 18812 - SIP Patron status does not respect OverduesBlockCirc (4.44 KB, patch)
2017-06-17 14:19 UTC, Chris Kirby
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2017-06-15 15:05:23 UTC
When performing a patron_information request against the SIP server a patron with overdues returns false for 'charge privileges denied' - they should return a 'Y'
Comment 1 Nick Clemens 2017-06-15 15:11:13 UTC
Created attachment 64336 [details] [review]
Bug 18812 - SIP Patron status does not respect OverduesBlockCirc

To test:
1 - Set 'OverduesBlockCirc' to block
2 - Find or create a patron with overdues
3 - Perform a SIP patron lookup on that patron
misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL
--patron {userid or cardnumber} --password {pass} -m patron_information
4 - Note the first character of response is a ' '
5 - Apply patch
6 - Perform SIP patron lookup
7 - Note the first character of response is 'Y'
8 - prove t/db_dependent/SIP/Patron.t
9 - Test should return green
Comment 2 Chris Kirby 2017-06-17 14:19:38 UTC
Created attachment 64420 [details] [review]
Bug 18812 - SIP Patron status does not respect OverduesBlockCirc

To test:
1 - Set 'OverduesBlockCirc' to block
2 - Find or create a patron with overdues
3 - Perform a SIP patron lookup on that patron
misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL
--patron {userid or cardnumber} --password {pass} -m patron_information
4 - Note the first character of response is a ' '
5 - Apply patch
6 - Restart memcached, apache, and plack
7 - Perform SIP patron lookup
8 - Note the first character of response is 'Y'
9 - prove t/db_dependent/SIP/Patron.t
10 - Test should return green

Signed-off-by: Chris Kirby <chris.kirby@ilsleypubliclibrary.org>
Works as advertised