Bug 18845 - Encoding problem with subjects of list and cart emails
Summary: Encoding problem with subjects of list and cart emails
Status: RESOLVED DUPLICATE of bug 13245
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-22 11:41 UTC by Katrin Fischer
Modified: 2018-11-23 10:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18845: Fix encoding of cart and list email subjects (3.19 KB, patch)
2018-11-23 10:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-06-22 11:41:29 UTC
To test:
- Create a list, name it: Jugendbücher (books for youths in German)
- Add some items to your list
- Email yourself the list
- Verify that the subject is broken: Your list: Jugendbücher

Tested on 16.11.08.
Comment 1 Marc Véron 2017-06-23 15:14:00 UTC
I tested on current master, both sending a list with title "Jugendbücher" from staff client and from OPAC.
No problems with mails received, in both mails the subject reads: 
"Your list: Jugendbücher"
Comment 2 Katrin Fischer 2017-06-23 17:27:06 UTC
Hm interesting, wonder if it could be a difference in setup/mail client? Or something really different between master and 16.11.
Comment 3 Marc Véron 2017-06-23 18:03:27 UTC
(In reply to Katrin Fischer from comment #2)
> Hm interesting, wonder if it could be a difference in setup/mail client? Or
> something really different between master and 16.11.

I tested with Thunderbird on PC and with my Fairphone - mails displayed as expected.

Not sure, wasn't there a bug regarding double quotes in list titles? - Hmm, can not find it.
Comment 4 Katrin Fischer 2017-06-23 20:48:26 UTC
Thx for checking Marc, when I get time I will try to git bisect it.
Comment 5 Katrin Fischer 2017-08-17 12:17:45 UTC
Tested on master using mutt and it seems ok there.
Tested on 16.11.10 with Thunderbird - display is ok.
But in the web interface of web.de it's still broken: Your list : Jugendbücher

Is it possible we are double encoding here? 
132     $mail{subject} = Encode::encode("UTF-8", $mail{subject});
Comment 6 Katrin Fischer 2017-08-17 12:21:30 UTC
Hm, commenting that out breaks things. (In reply to Katrin Fischer from comment #5)
> 
> Is it possible we are double encoding here? 
> 132     $mail{subject} = Encode::encode("UTF-8", $mail{subject});

Commenting that line out breaks the display in mutt. So probably not.
Comment 7 Katrin Fischer 2017-08-18 10:33:10 UTC

*** This bug has been marked as a duplicate of bug 13245 ***
Comment 8 Katrin Fischer 2018-11-23 10:38:53 UTC
Created attachment 82602 [details] [review]
Bug 18845: Fix encoding of cart and list email subjects

I have some problem with git bz/devbox... attaching the old way.
Comment 9 Katrin Fischer 2018-11-23 10:40:14 UTC
Comment on attachment 82602 [details] [review]
Bug 18845: Fix encoding of cart and list email subjects

This was to go on another bug.