Bug 1889 - Virtual shelves leave blank field in staff intranet when BIB is deleted
Summary: Virtual shelves leave blank field in staff intranet when BIB is deleted
Status: VERIFIED REMIND
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: rel_3_0
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Galen Charlton
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-26 06:35 UTC by Chris Cormack
Modified: 2010-01-05 10:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:35:47 UTC


---- Reported by drdrulm@yahoo.com 2008-02-26 06:35:37 ----

When a BIB is in a virtual shelf, a blank field is left when the BIB is deleted. More than one blank field can appear in a list. There does not seem to be a delete button on the interface currently.



---- Additional Comments From drdrulm@yahoo.com 2008-02-26 07:07:47 ----

OK, I can see that these -are- deletable by user. So the owner can delete them. The blank entry is still there when the bib is deleted (does not seem to happen in the OPAC). Allowing the admin to override any virtual shelves could be useful.



---- Additional Comments From drdrulm@yahoo.com 2008-02-26 07:10:20 ----

Here is a shelf at smfpl-beta that shows this:
http://smfpl-beta.dev.kohalibrary.com:8080/cgi-bin/koha/virtualshelves/shelves.pl?viewshelf=336




---- Additional Comments From jmf@liblime.com 2008-03-17 21:50:38 ----

I'm not sure of the best solution here, maybe add a delete from virtualshelvescontents when deleting a bib record? Assigning to Galen to take a look, but low priority.



---- Additional Comments From gmcharlt@gmail.com 2008-03-18 12:34:12 ----

I think the simplest solution is to add a FK relationship between biblio and virtualshelves - there's no reason I can think of for a list to refer to bibs that no longer exist, nor any reason for the presence of a bib on a list to prevent deletion of the bib.



---- Additional Comments From gmcharlt@gmail.com 2008-03-18 13:05:07 ----

OK, it turns out the FK relationship between virtualshelfcontents and biblio already exists in the 3.0 codebase, and has existed for a long time.  Deleting a bib in my current test DB removes the entry from the list, so this is a WORKSFORME as far as Koha 3.0 HEAD is concerned.

I checked the SMFPL test database, and it appears that for some reason the constraint is not present.  Can you confirm that the database was upgraded from a 2.2.9 installation - it's possible that the problem ultimately lies in the upgrade process.



---- Additional Comments From chris.nighswonger@liblime.com 2008-06-19 13:44:30 ----

*** http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1963 has been marked as a duplicate of this bug. ***



---- Additional Comments From nengard@gmail.com 2009-12-23 17:58:51 ----

This bug hasn't been touched in nearly a year, please revisit and test and close if appropriate.



---- Additional Comments From pascale.nalon@ensmp.fr 2010-01-05 10:37:54 ----

OK, in Koha 3.0.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:35 UTC  ---

This bug was previously known as _bug_ 1889 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1889

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was drdrulm@yahoo.com.