This patchset adds a parameter to the koha-conf.xml file: <elasticsearch_admin_password> When defined additional actions will be enabled on the Search engine configuration page Password must be entered and action chosen, if password matches the action will be performed
Created attachment 65088 [details] [review] Bug 18950 - Elasticsearch - Add password access for admin functions To test: 1 - Load 'Search engine configuration' from admin page http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl 2 - Verify this works as before the patch 3 - Add <elasticsearch_admin_password> to koha-conf.xml 4 - Reload search config page, note additional option to reset mappings 5 - Attempt reset with bad password 6 - Attempt reset with correct password Note: the action is a drop down as reindexing will be added, however, code needs some refactoring before this option can be implemented
Created attachment 65160 [details] [review] Bug 18950 - Elasticsearch - Add password access for admin functions To test: 1 - Load 'Search engine configuration' from admin page http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl 2 - Verify this works as before the patch 3 - Add <elasticsearch_admin_password> to koha-conf.xml 4 - Reload search config page, note additional option to reset mappings 5 - Attempt reset with bad password 6 - Attempt reset with correct password 7 - Attempt a reindex with bad password 8 - Attempt a reindex with correct password
Patch applies, and basic functionality is there, however: - "Reindex" checked for password correctly but failed since 18948 does not apply for me (not an issue, just a note) - The password input field is of type=text but should be of type=password - The error message when you enter a wrong password should probably more obvious (like being red, or using the standard koha warning boxes) - I'd suggest moving the <elasticsearch_admin_password> XML node inside the <elasticsearch> group, seems cleaner to me.
Not working on this one