Bug 19039 - Results of virtual shelves (lists) not sortable by date added
Summary: Results of virtual shelves (lists) not sortable by date added
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Maryse Simard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 18698
  Show dependency treegraph
 
Reported: 2017-08-04 14:19 UTC by Marc Véron
Modified: 2020-01-06 20:17 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 19039: Results of virtual shelves (lists) not sortable by date (3.04 KB, patch)
2018-06-22 21:47 UTC, Maryse Simard
Details | Diff | Splinter Review
Bug 19039: Results of virtual shelves (lists) not sortable by date (3.18 KB, patch)
2018-07-04 01:33 UTC, Dilan Johnpullé
Details | Diff | Splinter Review
Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date (8.36 KB, patch)
2018-07-27 20:12 UTC, Maryse Simard
Details | Diff | Splinter Review
Bug 19039: Results of virtual shelves (lists) not sortable by date (3.23 KB, patch)
2018-08-07 14:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date (8.41 KB, patch)
2018-08-07 14:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19039: Results of virtual shelves (lists) not sortable by date (3.28 KB, patch)
2018-08-10 13:55 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date (8.47 KB, patch)
2018-08-10 13:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2017-08-04 14:19:25 UTC
To verify: In staff client, create a list with several items and display it. Verify that the table is sortable by 'Title', 'Author', 'Call number', but not by 'Date added'
Comment 1 Maryse Simard 2018-06-22 21:47:09 UTC Comment hidden (obsolete)
Comment 2 Dilan Johnpullé 2018-07-04 01:33:15 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2018-07-06 07:32:30 UTC
Not a bugfix but an enhancement. This field is important for the release maintainers. Please check next time.
Assignee was not filled. Patch complexity not filled. These fields are helpful for QA.
Comment 4 Marcel de Rooy 2018-07-06 07:48:38 UTC
QA Comment:
When you edit a list, you can define its sort order: title, author, copyright date or callnumber.
All other (sortable) columns in the staff list view are in that group. Dateadded is not. Somehow it feels inconsistent not to add this column to that group.
And allow the same sort order on OPAC.
Not a blocker for me but at least reason for feedback.
Comment 5 Maryse Simard 2018-07-27 20:12:53 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2018-08-01 16:46:00 UTC
After creating a list which is sorted by default by date added, when I view it in the OPAC the "Sort by" dropdown doesn't have "Date added" preselected. Everything else looks good.
Comment 7 Maryse Simard 2018-08-03 19:46:54 UTC
(In reply to Owen Leonard from comment #6)
> After creating a list which is sorted by default by date added, when I view
> it in the OPAC the "Sort by" dropdown doesn't have "Date added" preselected.

Hmm... when I test it myself, I do not encounter this problem ("Date added" is properly preselected). Also, looking at the patch, it seems as though the situation should be handled correctly...

Could I have you look at it one more time and confirm the problem does occur for you?
Comment 8 Owen Leonard 2018-08-07 14:26:30 UTC
Created attachment 77535 [details] [review]
Bug 19039: Results of virtual shelves (lists) not sortable by date

In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'.

Test plan:
1) In the staff client, view a list containing several items
2) Notice that you can't sort by 'date added'
3) Apply the patch
4) Repeat step 1
5) The list can now be sorted by 'date added'

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 9 Owen Leonard 2018-08-07 14:26:34 UTC
Created attachment 77536 [details] [review]
Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date

    In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'.

    This patch adds 'date added' as an option for default sorting of lists. It also makes it available as a sorting option while viewing lists.

    Test plan:
    In the staff client and the opac:
    1) View a list containing several items
      => Notice that you can't sort by 'date added'
    2) Try to edit the list or create a new one
      => Notice you can't choose date added as the default sort order
    3) Apply the patch
    4) When viewing the list you should now be able to sort by date added
      => Make sure it orders correctly
    5) Edit or create a list and choose date added as default sorting order
      => Make sure it uses date added as default
      => On the staff client: test that the filter for 'sort by' works for date added
      => On the opac: test that, while viewing the contents, choosing 'default sorting' in the dropdown menu sorts correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 10 Owen Leonard 2018-08-07 14:27:26 UTC
(In reply to Maryse Simard from comment #7)
> Could I have you look at it one more time and confirm the problem does occur
> for you?

I guess I was wrong!
Comment 11 Katrin Fischer 2018-08-10 13:55:19 UTC
Created attachment 77669 [details] [review]
Bug 19039: Results of virtual shelves (lists) not sortable by date

In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'.

Test plan:
1) In the staff client, view a list containing several items
2) Notice that you can't sort by 'date added'
3) Apply the patch
4) Repeat step 1
5) The list can now be sorted by 'date added'

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 12 Katrin Fischer 2018-08-10 13:55:23 UTC
Created attachment 77670 [details] [review]
Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date

    In the staff client, when viewing the content of a list, it can be sorted by 'title', 'author' or 'call number' but not by 'date added'.

    This patch adds 'date added' as an option for default sorting of lists. It also makes it available as a sorting option while viewing lists.

    Test plan:
    In the staff client and the opac:
    1) View a list containing several items
      => Notice that you can't sort by 'date added'
    2) Try to edit the list or create a new one
      => Notice you can't choose date added as the default sort order
    3) Apply the patch
    4) When viewing the list you should now be able to sort by date added
      => Make sure it orders correctly
    5) Edit or create a list and choose date added as default sorting order
      => Make sure it uses date added as default
      => On the staff client: test that the filter for 'sort by' works for date added
      => On the opac: test that, while viewing the contents, choosing 'default sorting' in the dropdown menu sorts correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Nick Clemens 2018-08-24 16:32:01 UTC
Awesome work all!

Pushed to master for 18.11
Comment 14 Martin Renvoize 2018-09-05 07:54:35 UTC
Enhancement, won't be backported to 18.05.x series.