Bug 19043 - Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available.
Summary: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available.
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Z39.50 / SRU / OpenSearch Servers (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Josef Moravec
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-04 20:03 UTC by Barton Chittenden
Modified: 2017-10-09 19:18 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available (5.84 KB, patch)
2017-08-08 14:34 UTC, Josef Moravec
Details | Diff | Splinter Review
[SIGNED OFF] Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available (5.91 KB, patch)
2017-08-08 21:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available (5.99 KB, patch)
2017-10-09 10:55 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 19043: (QA follow-up) Add dbrev and print warning (1.55 KB, patch)
2017-10-09 10:55 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Barton Chittenden 2017-08-04 20:03:12 UTC
Per http://library.columbia.edu/find/clio/legacy-help/CLIOLegacy-Z3950.html,

"Z39.50 users: Access to CLIO via the Z39.50 protocol is now restricted to on-campus use. For information about using Z39.50 to search CLIO, please see: http://library.columbia.edu/find/clio/classic-help/z3950.html"

This target is one of the sample servers loaded in community koha, it should be removed from the list of z39.50 servers in the database.
Comment 1 Josef Moravec 2017-08-08 14:34:30 UTC
Created attachment 65641 [details] [review]
Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available

Test plan:
0) Apply the patch
1) Install all affected languages: de-DE, es-ES, fr-CA and pl-PL
2) Remove and recreate Koha database
3) Go through web installer in English and don't forgot to load sample Z39.50 servers
4) Go to Administration -> Z39.50/SRU Servers and confirm the sample
servers are here, but columbia.edu is not here
5) Repeat 2-4 for other languages: de-DE, es-ES, fr-CA and pl-PL
Comment 2 Katrin Fischer 2017-08-08 21:52:51 UTC
Created attachment 65692 [details] [review]
[SIGNED OFF] Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available

Test plan:
0) Apply the patch
1) Install all affected languages: de-DE, es-ES, fr-CA and pl-PL
2) Remove and recreate Koha database
3) Go through web installer in English and don't forgot to load sample Z39.50 servers
4) Go to Administration -> Z39.50/SRU Servers and confirm the sample
servers are here, but columbia.edu is not here
5) Repeat 2-4 for other languages: de-DE, es-ES, fr-CA and pl-PL

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Jonathan Druart 2017-08-09 17:38:46 UTC
Should we display a message on the about page and/or during the update database process?
Comment 4 Barton Chittenden 2017-08-09 17:53:15 UTC
(In reply to Jonathan Druart from comment #3)
> Should we display a message on the about page and/or during the update
> database process?

I would say both. More communication is generally better.

Verbosely,

--Barton
Comment 5 Josef Moravec 2017-08-09 18:13:46 UTC
(In reply to Jonathan Druart from comment #3)
> Should we display a message on the about page and/or during the update
> database process?

Good idea, I'll try to implement it, so changing status to assigned.
Comment 6 Katrin Fischer 2017-08-09 18:55:44 UTC
Hm, I think the about page is really getting slow. Maybe an updatedatabase entry is enough in this case as it's not structural issue.
Comment 7 Jonathan Druart 2017-08-09 19:22:46 UTC
(In reply to Katrin Fischer from comment #6)
> Hm, I think the about page is really getting slow. Maybe an updatedatabase
> entry is enough in this case as it's not structural issue.

I am not sure this argument is relevant. You are not supposed to hit this page everyday.
But in this case it may be not necessary to add this check.
Comment 8 Marcel de Rooy 2017-10-09 10:55:41 UTC
Created attachment 67837 [details] [review]
Bug 19043: Z39.50 target clio-db.cc.columbia.edu:7090 is no longer publicly available

Test plan:
0) Apply the patch
1) Install all affected languages: de-DE, es-ES, fr-CA and pl-PL
2) Remove and recreate Koha database
3) Go through web installer in English and don't forgot to load sample Z39.50 servers
4) Go to Administration -> Z39.50/SRU Servers and confirm the sample
servers are here, but columbia.edu is not here
5) Repeat 2-4 for other languages: de-DE, es-ES, fr-CA and pl-PL

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Marcel de Rooy 2017-10-09 10:55:45 UTC
Created attachment 67838 [details] [review]
Bug 19043: (QA follow-up) Add dbrev and print warning

This follow-up takes care of the requested warning at upgrade time.
At the same time it removes the obsolete Columbia record when host and
port are equal to the formerly used values. Note that the new host for
on-campus use has been changed.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Jonathan Druart 2017-10-09 19:18:32 UTC
Pushed to master for 17.11, thanks to everybody involved!