Bug 19076 - Renewal via Checkout screen is logged as both a renewal and a checkout
Summary: Renewal via Checkout screen is logged as both a renewal and a checkout
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 17708
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-10 14:58 UTC by Nick Clemens
Modified: 2017-08-12 22:12 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19076 - unit tests (2.23 KB, patch)
2017-08-10 15:24 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19076 - Move issue logging in AddIssue into condtional clause (1.54 KB, patch)
2017-08-10 15:24 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19076 - unit tests (2.55 KB, patch)
2017-08-11 15:36 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19076 - Move issue logging in AddIssue into condtional clause (1.54 KB, patch)
2017-08-11 15:36 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19076 - followup - delete fines from additional renewal (1.05 KB, patch)
2017-08-11 15:40 UTC, Nick Clemens
Details | Diff | Splinter Review
[SIGNED OFF ] Bug 19076 - followup - delete fines from additional renewal (1.13 KB, patch)
2017-08-12 22:12 UTC, Christopher Brannon
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2017-08-10 14:58:04 UTC
To recreate:
1 - Enable both issue and renewal logs
2 - Checkout an item to a patron
3 - View the logs - the issue is captured
4 - Checkout the item to the patron again and confirm renewal
5 - Both an issue and a renewal are logged
Comment 1 Nick Clemens 2017-08-10 15:24:21 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2017-08-10 15:24:24 UTC Comment hidden (obsolete)
Comment 3 Nick Clemens 2017-08-11 15:36:53 UTC
Created attachment 65907 [details] [review]
Bug 19076 - unit tests
Comment 4 Nick Clemens 2017-08-11 15:36:56 UTC
Created attachment 65908 [details] [review]
Bug 19076 - Move issue logging in AddIssue into condtional clause

Currently AddIssue tests if renewal, but logs an issue even if so. This
patch moves the logging into the conditional so a log entry is only
added if we aren't renewing (as renewals are logged separately)

To test:
1 - prove t/db_dependent/Circulation.t - one test should fail
2 - Enable both issue and renewal logs
3 - Checkout an item to a patron
4 - View the logs - the issue is captured
5 - Checkout the item to the patron again and confirm renewal
6 - Both an issue and a renewal are logged
7 - Apply patch
8 Repeat 1-6, tests should pass and only renewal should be logged
Comment 5 Nick Clemens 2017-08-11 15:40:44 UTC
Created attachment 65916 [details] [review]
Bug 19076 - followup - delete fines from additional renewal
Comment 6 Christopher Brannon 2017-08-12 18:36:38 UTC
Please rebase.
Comment 7 Nick Clemens 2017-08-12 19:36:04 UTC
Applies cleanly for me on master, can you pull and retest?
Comment 8 Christopher Brannon 2017-08-12 22:12:44 UTC
Created attachment 65939 [details] [review]
[SIGNED OFF ] Bug 19076 - followup - delete fines from additional renewal

Works as described.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>