Created attachment 66559 [details] what this looks like When displaying the fines of the guarantee on the guarantor account, price is not in correct format. Currently if the price is 7.50 the price shows up as 7.5 . Fees & Charges: Patron's guarantees collectively owe...
Created attachment 66560 [details] [review] Bug 19193 - When displaying the fines of the guarantee on the guarantor account, price is not in correct format 1 - Have a patron with guarantees 2 - Charge some fines to the guarantees 3 - View the patron 4 - Fines are displayed unformatted 5 - Apply patch 6 - Refresh 7 - Fines should now be formatted correctly
I'm not getting the message at all (without patch). I added guarantees to a patron and charged fines to one of the guarantees. I see the message in the guarantee's account, but not in the guarantor's. Unable to reproduce.
My apologies, I missed some steps, you need to have NoIssuesChargeGuarantees set to make the message show: Add steps: 2.5 - Set system preference 'NoIssuesChargeGuarantees' to '0' (or just make sure patrons have more than the number you set) 4.5 - Check display with both values of system preference 'AllowFineOverride'
Created attachment 67154 [details] [review] Bug 19193 - When displaying the fines of the guarantee on the guarantor account, price is not in correct format 1 - Have a patron with guarantees 2 - Charge some fines to the guarantees 3 - View the patron 4 - Fines are displayed unformatted 5 - Apply patch 6 - Refresh 7 - Fines should now be formatted correctly Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Yes! It worked!
Created attachment 67666 [details] [review] Bug 19193 - When displaying the fines of the guarantee on the guarantor account, price is not in correct format 1 - Have a patron with guarantees 2 - Charge some fines to the guarantees 3 - View the patron 4 - Fines are displayed unformatted 5 - Apply patch 6 - Refresh 7 - Fines should now be formatted correctly Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14.
Pushed to 16.05.x, for 16.05.19 release