Bug 1920 - Total price not saving to order
Summary: Total price not saving to order
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: rel_3_0
Hardware: Macintosh All
: PATCH-Sent (DO NOT USE) blocker (vote)
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-06 05:45 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Info I entered (34.90 KB, image/png)
2008-03-06 05:45 UTC, Chris Cormack
Details
Info that appeared (44.19 KB, image/png)
2008-03-06 05:46 UTC, Chris Cormack
Details
What i saw when i tried to edit (18.85 KB, image/png)
2008-03-06 05:46 UTC, Chris Cormack
Details
order with actual cost (22.00 KB, image/png)
2008-06-02 08:19 UTC, Chris Cormack
Details
invoice without actual cost (37.94 KB, image/png)
2008-06-02 08:19 UTC, Chris Cormack
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:36:09 UTC


---- Reported by nengard@gmail.com 2008-03-06 05:45:13 ----

See attached images.  When I place an order from a suggestion, it seems to erase the amounts I enter into the Total fields.  I'm trying to write the manual, but need to stop here until this bug is fixed.



---- Additional Comments From nengard@gmail.com 2008-03-06 05:45:34 ----

Created an attachment
Info I entered





---- Additional Comments From nengard@gmail.com 2008-03-06 05:46:03 ----

Created an attachment
Info that appeared





---- Additional Comments From nengard@gmail.com 2008-03-06 05:46:34 ----

Created an attachment
What i saw when i tried to edit





---- Additional Comments From joe.atzberger@liblime.com 2008-03-06 13:22:44 ----

This is a mutli-level problem.  

The forms were actually OK, but they require javascript to calculate/populate all the fields.  The javascript was halting on an error involving undefined value for the hidden input "currency" that is pulled from $bookseller->{'listprice'}.  

The script on the back end should reproduce the auto-population for empty fields so that the effect is not script-dependent.

It actually does ZERO error checking and unconditionally prints a redirect, even if the add fails.  This should be considered a separate, larger bug.  



---- Additional Comments From joe.atzberger@liblime.com 2008-03-06 23:16:53 ----

Patch send (along w/ other patches for acq. related problems).  Please test once changes are pushed up and confirm proper operation.



---- Additional Comments From gmcharlt@gmail.com 2008-05-30 13:58:14 ----

The patches to fix this bug have been pushed.  Nicole, please test and close this bug.



---- Additional Comments From nengard@gmail.com 2008-06-02 08:18:56 ----

This works - but if I enter an 'Actual Cost' it does not appear on the invoice? What is this field for?  See attachments.



---- Additional Comments From nengard@gmail.com 2008-06-02 08:19:18 ----

Created an attachment
order with actual cost





---- Additional Comments From nengard@gmail.com 2008-06-02 08:19:45 ----

Created an attachment
invoice without actual cost





---- Additional Comments From joe.atzberger@liblime.com 2008-06-04 08:31:57 ----

(In reply to comment #7)
> This works - but if I enter an 'Actual Cost' it does not appear on the invoice?
> What is this field for?  See attachments.
> 

I think it is for a different means of valuation, like estimating total worth of the collection.  If nothing else, you'd need a field other than "replacement cost" for items that are irreplaceable.  AFAIK, it doesn't have any bearing on invoices, so I'm closing this bug.




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:36 UTC  ---

This bug was previously known as _bug_ 1920 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1920
Imported an attachment (id=411)
Imported an attachment (id=412)
Imported an attachment (id=413)
Imported an attachment (id=414)
Imported an attachment (id=415)

Actual time not defined. Setting to 0.0
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, chris@bigballofwax.co.nz.
   Previous assignee was rch@liblime.com.
The original submitter of attachment 411 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 412 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 413 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 414 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 415 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.