Created attachment 66784 [details] attachment shows item with status on hold in cart showing as available Items that have status of on hold show as available on cart list. While users can observe the item has the status of on hold before putting it in the cart, it was reported some patrons find this inconsistency confusing.
This bug has been showing "New" for 8 months. Owen, might we take a look at this and see what we can do? Ed
I just got a complaint on this. Could someone please fix it? Thanks NancyK
Created attachment 88093 [details] [review] Bug 19241: Waiting items show as available in the cart The cart uses the same item-status.inc that the details page uses, however, we don't set the waiting or reserved flags. This patch adds those flags to the script To test: 1 - Find an item on the opac 2 - Place a hold on the item 3 - Check in the item to confirm the hold 4 - Note the details page on OPAC shows 'On hold' 5 - Add the item to a basket 6 - Note the basket shows 'Available' 7 - Apply patch 8 - Check the cart, should show as 'On hold'
Created attachment 88127 [details] [review] Bug 19241: Waiting items show as available in the cart The cart uses the same item-status.inc that the details page uses, however, we don't set the waiting or reserved flags. This patch adds those flags to the script To test: 1 - Find an item on the opac 2 - Place a hold on the item 3 - Check in the item to confirm the hold 4 - Note the details page on OPAC shows 'On hold' 5 - Add the item to a basket 6 - Note the basket shows 'Available' 7 - Apply patch 8 - Check the cart, should show as 'On hold' Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 88690 [details] [review] Bug 19241: Waiting items show as available in the cart The cart uses the same item-status.inc that the details page uses, however, we don't set the waiting or reserved flags. This patch adds those flags to the script To test: 1 - Find an item on the opac 2 - Place a hold on the item 3 - Check in the item to confirm the hold 4 - Note the details page on OPAC shows 'On hold' 5 - Add the item to a basket 6 - Note the basket shows 'Available' 7 - Apply patch 8 - Check the cart, should show as 'On hold' Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
No regressions found, simple fix. Thanks all, Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.05
can't rebase for 18.05.x Global symbol "$borcat" requires explicit package name (did you forget to declare "my $borcat"?)