Created attachment 66792 [details] [review] Bug 18645 -Koha feature release change tool This tool is displayed at the end of the update process to display all the new system preferences added during the update so that the administrator can view and modify their default values if neccessary Link to the release notes for the most recent installed release are also provided by this tool. Test plan: 1. Go to Administrator->global system preferences->Local use 2. Set the version number to 16.1200033 (Note: only 1 decimal place) and save 3. Go through the update process and notice that after submitting the 'Update database structure" page you are prompted to login and the main page appears if you logged in with the correct credentials 4. Apply patch 5. Repeat steps 1, and 2 6. Notice the button text on the 'Update database structure' page has changed and now it says 'Continue to feature release tool' 7. The feature release tool will be displayed. Click on the 'New Syspref information' tab and notice that the system preferences (names, explanations and (editable) default values) installed in the update process are displayed 8. Change the value of TranslateNotices syspref and click the 'Save all preferences' button 9. Refresh the page manually and click on the 'New syspref information' tab and notice the value of the TranslateNotices syspref has been altered 10. Click on the 'Release notes' tab and open the release note link which is 17.05 release notes 11. Leave the feature release change tool by clicking the 'Next and submit' button 12. You are prompted to login, after entering the correct credentials the intranet main page is displayed Sponsored-by: Catalyst IT
Created attachment 67415 [details] [review] Bug 19247 - Followup: QA test tool fixes Test plan: 1. Run QA test tools and notice that all files pass
Created attachment 67419 [details] [review] Bug 19247 - Followup: QA test tool fixes Test plan: 1. Run QA test tools and notice that all files pass
Created attachment 68113 [details] [review] Bug 18645 -Koha feature release change tool This tool is displayed at the end of the update process to display all the new system preferences added during the update so that the administrator can view and modify their default values if neccessary Link to the release notes for the most recent installed release are also provided by this tool. Test plan: 1. Go to Administrator->global system preferences->Local use 2. Set the version number to 16.1200033 (Note: only 1 decimal place) and save 3. Go through the update process and notice that after submitting the 'Update database structure" page you are prompted to login and the main page appears if you logged in with the correct credentials 4. Apply patch 5. Repeat steps 1, and 2 6. Notice the button text on the 'Update database structure' page has changed and now it says 'Continue to feature release tool' 7. The feature release tool will be displayed. Click on the 'New Syspref information' tab and notice that the system preferences (names, explanations and (editable) default values) installed in the update process are displayed 8. Change the value of TranslateNotices syspref and click the 'Save all preferences' button 9. Refresh the page manually and click on the 'New syspref information' tab and notice the value of the TranslateNotices syspref has been altered 10. Click on the 'Release notes' tab and open the release note link which is 17.05 release notes 11. Leave the feature release change tool by clicking the 'Next and submit' button 12. You are prompted to login, after entering the correct credentials the intranet main page is displayed Sponsored-by: Catalyst IT
Created attachment 68114 [details] [review] Bug 19247 - Followup: QA test tool fixes Test plan: 1. Run QA test tools and notice that all files pass
Created attachment 68115 [details] [review] Bug 19247 - Working on displaying the values of the system preferences in correct format Sponsored-By: Catalyst IT
Hi Alex, check the system preference editor - I just noticed I still had your patch from before applied and it seemed to break the pull downs in the editor.
Just took a look at the last patch, what is display_choices supposed to do? display_choices="Don't show|Show" WHERE variable="IntranetCatalogSearchPulldown"; On first glance, this looks like a translatability issue - why have them in the database and in the translatable yaml file?
Hi Katrin Sorry for not replying sooner. The purpose of display_choices is a way of displaying option values in the feature Release Change Tool. I cannot use the YAML files because they are organised by their functionality, e.g. there is a admin.pref for all administration related system preferences. I want to retrieve and display the system preferences by the version they were added in and so it would require a very complex regular expression to go through each of the YAML files to find the system preference with a matching name. Whereas by having the display_choices values in the database in records containing the version number I can both retrieve the system preference information and display information in one go. So that was my rationale for the display_choices. I hope that makes sense :)
Hmm the problem with the db, is it is not translatable, which will make this tool not useful for non English users. (which is a lot of the world) Also they will get out of sync with the yaml files pretty fast. Maybe look into the code that does the syspref search now, and see if you can reuse that? It is searching over the yaml files
This looks like a great feature.. are you intending to breathe any further life into it Alex... be another great one to showcase in 18.11.
Hi Martin Thanks very much. Yes, I would like to breathe more life into this one. I have been busy testing patches over the last while, I can start working on revisiting this one tonight to try to move it along. Will be in touch when it is ready to test :) Cheers, Alex
This does sound cool!
So we missed 18.11 and we're about to miss 19.05. Mind if I adopt this one at the beginning of the next cycle so we can get it in there for 19.11?
So, a little bird told me you're back from an amazing break and feel refreshed and raring to go Alex... is this bug still on your horizon?
Hi Martin, Yes I have returned from an amazing break! The patches on this bug report are a duplicate of bug 18645 so perhaps we should mark this bug report as a duplicate and concentrate on 18645. How does that sound? Aleisha has been doing some work rebasing 18645 and I think if we all work together on 18645 we should be able to move that along. Cheers, Alex
Martin, do you want to mark as duplicate as Alex suggests? Didn't want to change the RM_Priority :)
*** This bug has been marked as a duplicate of bug 18645 ***