Bug 19250 - Add pagination to /acquisitions/vendors
Summary: Add pagination to /acquisitions/vendors
Alias: None
Product: Koha
Classification: Unclassified
Component: REST api (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact:
URL: https://wiki.koha-community.org/wiki/...
Depends on: 19686
Blocks: 19757
  Show dependency treegraph
Reported: 2017-09-04 18:38 UTC by Tomás Cohen Arazi
Modified: 2018-04-13 19:28 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:

Bug 19250: Add /acquisitions/vendors pagination (3.38 KB, patch)
2017-11-23 20:27 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2017-09-04 18:38:50 UTC
The vendors listing endpoint should provide a way to have pagination. Should be straightforward with bug 19196.
Comment 1 Tomás Cohen Arazi 2017-11-23 20:27:03 UTC
Created attachment 69317 [details] [review]
Bug 19250: Add /acquisitions/vendors pagination

This patch makes the /acquisitions/vendors endpoint paginated and handle
the new special params introduced by 19410: _match, _order_by_, _page
and _per_page.

To do so, the OpenAPI spec is updated with the new parameters, and
_to_model is rewritten to avoid autovivification, as required by the
extension of the objects.search helper, introduced by bug 19686.
Comment 2 Maksim Sen 2018-04-13 19:20:42 UTC
Could I have a test plan to sign off this bug?
Comment 3 Tomás Cohen Arazi 2018-04-13 19:28:53 UTC
(In reply to Maksim Sen from comment #2)
> Could I have a test plan to sign off this bug?

Hi, I'm working on a broader rewrite of this endpoint implementing the voted RFC.