If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors: # Failed test 'POD spelling for ./acqui/invoice.pl' # at xt/author/pod_spell.t line 21. # Errors: # pl # Failed test 'POD spelling for ./acqui/neworderempty.pl' # at xt/author/pod_spell.t line 21. # Errors: # CGI # MARCfindbreeding # basketno # biblio # booksellerid # breedingid # neworderempty # ordernumber # pl # suggestionid # Failed test 'POD spelling for ./acqui/addorder.pl' # at xt/author/pod_spell.t line 21. # Errors: # CGI # ISBN # addorder # biblio # cgi # copyrightdate # neworderbiblio # neworderempty # newordersuggestion # pl And much more... Let's remove this file
Created attachment 66871 [details] [review] Bug 19262: Remove xt/author/pod_spell.t If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors. Let's remove this file
Created attachment 66896 [details] [review] Bug 19262: Remove xt/author/pod_spell.t If you run `prove xt/author/pod_spell.t` without having Test::Spelling installed, it will skip the tests. If you install the lib-test-spelling-perl, the test will fail: xt/author/pod_spell.t .. You said to run 0 tests at xt/author/pod_spell.t line 21. xt/author/pod_spell.t .. Dubious, test returned 25 (wstat 6400, 0x1900) No subtests run This is because the call to all_pod_files_spelling_ok is expecting a path If we try to fix it with adding "." as parameter, the tests will raise tone of errors. Let's remove this file Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed to master for 17.11, thanks to everybody involved!
Pushed to 17.05.x, will be in 17.05.06.
This patch has been pushed to 16.11.x and will be in 16.11.14.
Pushed to 16.05.x, for 16.05.19 release