Bug 19340 - Transferred orders show incorrect basket in transferred from/to
Summary: Transferred orders show incorrect basket in transferred from/to
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Colin Campbell
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 15531
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-19 11:52 UTC by Colin Campbell
Modified: 2017-10-09 19:19 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Patch to read correct basket data (1.02 KB, patch)
2017-09-19 12:07 UTC, Colin Campbell
Details | Diff | Splinter Review
Bug 19340 Read basket details of transfer partner (1.07 KB, patch)
2017-09-22 18:41 UTC, David Bourgault
Details | Diff | Splinter Review
Bug 19340 Read basket details of transfer partner (1.12 KB, patch)
2017-10-07 02:00 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2017-09-19 11:52:27 UTC
If you transfer an order from basket A to basket B The order in basket A is cancelled and should show "Transferred to basket B' A new order is created in basket B and should show Transferred from basket A.
Currently the orders erroneously show the same basket as the order is in
i.e.
Basket A shows transferred to Basket A
Basket B shows transferred from Basket B

The reason is the order does not read the basket details and inadvertantly defaults to the owning basket.
Comment 1 Colin Campbell 2017-09-19 12:07:53 UTC
Created attachment 67201 [details] [review]
Patch to read correct basket data

Simple patch can be easily tested.

Transfer an order line from one basket and supplier to another. When displaying the two baskets, the basketname and supplier appearing in the transferred from/to message in the orderline will incorrectly be those of the current basket.
Apply the patch and the supplier and basketname should display the correct values
Comment 2 David Bourgault 2017-09-22 18:41:08 UTC
Created attachment 67331 [details] [review]
Bug 19340 Read basket details of transfer partner

Details of the basket an order is tranferred to or from
are displayed in the basket display.
Unfortunately these details were not being read so
the display incorrectly showed the details
of the current owning basket.

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Comment 3 Nick Clemens 2017-10-07 02:00:11 UTC
Created attachment 67779 [details] [review]
Bug 19340 Read basket details of transfer partner

Details of the basket an order is tranferred to or from
are displayed in the basket display.
Unfortunately these details were not being read so
the display incorrectly showed the details
of the current owning basket.

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-10-09 17:18:08 UTC
Looks like it has been caused by
  commit 9501ac2feffa8aca965fd24156560870df4065c3
    Bug 15531: Add support for standing orders
Comment 5 Jonathan Druart 2017-10-09 19:19:16 UTC
Pushed to master for 17.11, thanks to everybody involved!