If you transfer an order from basket A to basket B The order in basket A is cancelled and should show "Transferred to basket B' A new order is created in basket B and should show Transferred from basket A. Currently the orders erroneously show the same basket as the order is in i.e. Basket A shows transferred to Basket A Basket B shows transferred from Basket B The reason is the order does not read the basket details and inadvertantly defaults to the owning basket.
Created attachment 67201 [details] [review] Patch to read correct basket data Simple patch can be easily tested. Transfer an order line from one basket and supplier to another. When displaying the two baskets, the basketname and supplier appearing in the transferred from/to message in the orderline will incorrectly be those of the current basket. Apply the patch and the supplier and basketname should display the correct values
Created attachment 67331 [details] [review] Bug 19340 Read basket details of transfer partner Details of the basket an order is tranferred to or from are displayed in the basket display. Unfortunately these details were not being read so the display incorrectly showed the details of the current owning basket. Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 67779 [details] [review] Bug 19340 Read basket details of transfer partner Details of the basket an order is tranferred to or from are displayed in the basket display. Unfortunately these details were not being read so the display incorrectly showed the details of the current owning basket. Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Looks like it has been caused by commit 9501ac2feffa8aca965fd24156560870df4065c3 Bug 15531: Add support for standing orders
Pushed to master for 17.11, thanks to everybody involved!