Bug 19409 - Around 130 images not migrated from DocBook XML to ReST format (Sphinx)
Summary: Around 130 images not migrated from DocBook XML to ReST format (Sphinx)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Documentation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-04 10:03 UTC by Zeno Tajoli
Modified: 2019-06-27 09:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Tajoli 2017-10-04 10:03:03 UTC 
The problem that is visible here:
https://koha-community.org/manual/17.05/html/04_patrons.html#check-out
, a two time ‘My checkouts’My checkouts is connect with an error on migration
from DocBook XML to ReST

In DocBook XML format (file manual.xml 16.05):
28167       <section id="patcheckout">
28168         <title><link linkend="patcheckout">Check Out</link></title>
28169
28170         <para>For instruction on checking items out, view the <link linkend="checkingout">Checking Out</link> section of this
28171         manual.</para>
28172         <para>Staff members can access their own check out screen by clicking their username in the
28173           top right of the staff client and choosing 'My checkouts'<screenshot>
28174             <screeninfo>My checkouts</screeninfo>
28175             <mediaobject>
28176               <imageobject>
28177                 <imagedata fileref="images/patrons/mycheckouts.png"/>
28178               </imageobject>
28179             </mediaobject>
28180           </screenshot></para>
28181       </section>


In ReST format (file 04_patrons.rst 16.11):
1129 `Check Out <#patcheckout>`__
1130 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1131
1132 For instruction on checking items out, view the `Checking
1133 Out <#checkingout>`__ section of this manual.
1134
1135 Staff members can access their own check out screen by clicking their
1136 username in the top right of the staff client and choosing 'My
1137 checkouts'My checkouts
1138
1139 `Details <#patrondetails>`__
1140 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

as you see the subsection <screenshot> ... </screenshot> is not well transformed into ReST format.

The correct transformation could be:

1129 `Check Out <#patcheckout>`__
1130 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1131
1132 For instruction on checking items out, view the `Checking
1133 Out <#checkingout>`__ section of this manual.
1134
1135 Staff members can access their own check out screen by clicking their
1136 username in the top right of the staff client and choosing 'My
1137 checkouts'
xxxx
xxxx My checkouts
xxxx |imageyyyy|
1138
1139 `Details <#patrondetails>`__


Seeking with regexp \S<screenshot>$ manual.xml (version 16.05) I find 133 results. Probably the lines where we need to fix
Comment 1 Jonathan Druart 2017-10-04 17:49:32 UTC 
I am working on a patch to fix these issues.
Comment 3 Katrin Fischer 2017-10-04 21:31:28 UTC 
Patches have been merged into master!