Bug 19414 - Move the location of the 'Import this batch into the catalog' button
Summary: Move the location of the 'Import this batch into the catalog' button
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic record staging/import (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Dilan Johnpullé
QA Contact: Nick Clemens
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-05 05:46 UTC by Dilan Johnpullé
Modified: 2017-10-11 16:54 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19414 - Move the location of the 'Import this batch into the catalog' button (1.99 KB, patch)
2017-10-05 06:06 UTC, Dilan Johnpullé
Details | Diff | Splinter Review
Bug 19414 - Move the location of the 'Import this batch into the catalog' button (2.05 KB, patch)
2017-10-07 12:51 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19414 - Move the location of the 'Import this batch into the catalog' button (2.10 KB, patch)
2017-10-10 23:32 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Dilan Johnpullé 2017-10-05 05:46:28 UTC
Logically reading the Manage staged MARC records page, the 'Import this batch into the catalog' button is above the dropdown selector for which framework to use.

This poses a problem if a user clicks the button before selecting which framework they want to import the batch as because it will be imported using the default framework otherwise.

The patch attached will move the button below the dropdown selector so as make everything appear in a more logical order.
Comment 1 Dilan Johnpullé 2017-10-05 06:06:54 UTC
Created attachment 67628 [details] [review]
Bug 19414 - Move the location of the 'Import this batch into the catalog' button

Moves the location of the button in question to be below the framework selector

Test plan:
1. Go to Tools -> Stage MARC records for import
2. Upload a .mrc file and stage it for import
3. Click Manage staged records
4. Note that the import button appears above the framework selector
5. Apply patch
6. Refresh the window
7. Notice that the button has now moved to below the framework selector

Sponsored-By: CALYX information essentials
Comment 2 Katrin Fischer 2017-10-07 12:51:59 UTC
Created attachment 67789 [details] [review]
Bug 19414 - Move the location of the 'Import this batch into the catalog' button

Moves the location of the button in question to be below the framework selector

Test plan:
1. Go to Tools -> Stage MARC records for import
2. Upload a .mrc file and stage it for import
3. Click Manage staged records
4. Note that the import button appears above the framework selector
5. Apply patch
6. Refresh the window
7. Notice that the button has now moved to below the framework selector

Sponsored-By: CALYX information essentials

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2017-10-07 12:52:14 UTC
Thx for your first patch, Dilan!
Comment 4 Nick Clemens 2017-10-10 23:32:38 UTC
Created attachment 67916 [details] [review]
Bug 19414 - Move the location of the 'Import this batch into the catalog' button

Moves the location of the button in question to be below the framework selector

Test plan:
1. Go to Tools -> Stage MARC records for import
2. Upload a .mrc file and stage it for import
3. Click Manage staged records
4. Note that the import button appears above the framework selector
5. Apply patch
6. Refresh the window
7. Notice that the button has now moved to below the framework selector

Sponsored-By: CALYX information essentials

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Jonathan Druart 2017-10-11 16:54:50 UTC
Pushed to master for 17.11, thanks to everybody involved!