When importing records, if there is an error in the staging we display: Failed to submit form: error This is not helpful, we should instead display the error textReponse field
Created attachment 67648 [details] [review] Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file form the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with all osrt of info
Note this changes the behavior of message in rancor, you now have to click to clear them, they don't clear on mouse move
The new message is not translatable, can you please fix?
The error is returned by the Ajax call, I don't know if we can make it translatable, I think we would have to define our own messages, but parsing out directories etc might be difficult. How would it be to preserve the existing but add a 'more details' option that would display this untranslatable text?
Created attachment 85353 [details] [review] Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info
Created attachment 85367 [details] [review] Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info
Created attachment 86033 [details] [review] Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info
Created attachment 86037 [details] [review] Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words.
Created attachment 86038 [details] [review] Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 86039 [details] [review] Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words.
Created attachment 86042 [details] [review] Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz>
Created attachment 86528 [details] [review] Bug 19417: Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86529 [details] [review] Bug 19417: Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 86530 [details] [review] Bug 19417: (QA follow-up) Fix missing $raw filter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Made a few minor corrections to make the QA scripts happy. Otherwise, a nice improvement which I think considerably improves feedback to the end user. I don't believe we can easily translate these error messages and do believe it's better to display them than to not display them so I'm Passing QA here even though it's untranslatable.
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.