Following bug 19487. QA follow-up moved to its own report.
Created attachment 68385 [details] [review] Bug 19513: More changes to MarkIssueReturned.t (after bug 19487) This patch was initially created as QA follow-up on 19487. $dbh is not used $categorycode is no longer used %item_branch_infos not used $borrowernumber is obsoleted by using $patron No real need for $anonymous_borrowernumber (Since MarkIssueReturned returns undef rightaway for an invalid itemnumber, the privacy stuff is irrelevant.) No AddMember calls, removing unneeded modules Adding a test that calls MarkIssueReturned on an item already returned. Test plan: [1] Run t/db_dependent/Circulation/MarkIssueReturned.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 68490 [details] [review] Bug 19513: Re-add AnonymousPatron-related tests These tests are still useful
Created attachment 68529 [details] [review] Bug 19513: Re-add AnonymousPatron-related tests These tests are still useful. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> The AddMember call is considerably slowing it down. A call to TestBuilder would be an improvement for performance.
use Koha::Checkouts ?
Pushed to master for 17.11, thanks to everybody involved!
Enhancement not pushed to 17.05.x