Bug 19519 - Ability to bind the rotating collection with branch during creating
Summary: Ability to bind the rotating collection with branch during creating
Status: BLOCKED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Keywords:
Depends on: 18606
Blocks: 19520
  Show dependency treegraph
 
Reported: 2017-10-23 18:06 UTC by Josef Moravec
Modified: 2018-07-02 11:58 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 19519: Add ability to bind rotating collectino with library during creation (5.94 KB, patch)
2017-12-05 18:13 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 19519: Add ability to bind rotating collectino with library during creation (5.96 KB, patch)
2018-03-13 21:02 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 19519: Add ability to bind rotating collectino with library during creation (5.99 KB, patch)
2018-03-25 19:40 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 19519: Add ability to bind rotating collectino with library during creation (5.97 KB, patch)
2018-03-28 15:29 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2017-10-23 18:06:08 UTC

    
Comment 1 Josef Moravec 2017-12-05 18:13:07 UTC
Created attachment 69542 [details] [review]
Bug 19519: Add ability to bind rotating collectino with library during creation

Test plan:
0) Apply the patch
1) Go to rotating collections tool
2) Try to create and edit collections, note there is new field
"library", try to set and unset it
3) try to transfer a collection, the library saved by creating/editing
collection should be preselected
Comment 2 Lucie Gay 2018-03-13 14:35:42 UTC
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 19519:
<h1>Something went wrong !</h1>Applying: Bug 19519: Add ability to bind rotating collectino with library during creation
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 19519: Add ability to bind rotating collectino with library during creation
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 19519 - Ability to bind the rotating collection with branch during creating

69542 - Bug 19519: Add ability to bind rotating collectino with library during creation
Comment 3 Josef Moravec 2018-03-13 21:02:21 UTC
Created attachment 72818 [details] [review]
Bug 19519: Add ability to bind rotating collectino with library during creation

Test plan:
0) Apply the patch
1) Go to rotating collections tool
2) Try to create and edit collections, note there is new field
"library", try to set and unset it
3) try to transfer a collection, the library saved by creating/editing
collection should be preselected
Comment 4 Josef Moravec 2018-03-13 21:03:58 UTC
Rebased
Comment 5 Lucie Gay 2018-03-14 09:02:13 UTC
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 19519:
<h1>Something went wrong !</h1>Applying: Bug 19519: Add ability to bind rotating collectino with library during creation
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 19519: Add ability to bind rotating collectino with library during creation
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 19519 - Ability to bind the rotating collection with branch during creating

72818 - Bug 19519: Add ability to bind rotating collectino with library during creation

Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-19519-Add-ability-to-bind-rotating-collectino--a2JeLJ.patch .
Comment 6 Josef Moravec 2018-03-25 19:40:41 UTC
Created attachment 73259 [details] [review]
Bug 19519: Add ability to bind rotating collectino with library during creation

Test plan:
0) Apply the patch
1) Go to rotating collections tool
2) Try to create and edit collections, note there is new field
"library", try to set and unset it
3) try to transfer a collection, the library saved by creating/editing
collection should be preselected
Comment 7 Josef Moravec 2018-03-28 15:29:43 UTC
Created attachment 73393 [details] [review]
Bug 19519: Add ability to bind rotating collectino with library during creation

Test plan:
0) Apply the patch
1) Go to rotating collections tool
2) Try to create and edit collections, note there is new field
"library", try to set and unset it
3) try to transfer a collection, the library saved by creating/editing
collection should be preselected
Comment 8 Cab Vinton 2018-07-02 08:53:39 UTC
The sandbox you've requested is not ready.

Some problems occurred applying patches from bug 19519:

<h1>Something went wrong !</h1>Applying: Bug 19519: Add ability to bind rotating collectino with library during creation
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt).
error: could not build fake ancestor

Patch failed at 0001 Bug 19519: Add ability to bind rotating collectino with library during creation
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 19519 - Ability to bind the rotating collection with branch during creating
Comment 9 Owen Leonard 2018-07-02 11:58:55 UTC
Depends on Bug 18606 which is currently Failed QA.