Bug 19538 - Advanced editor - Rancor - Move syspref from labs to cataloging and remove experimental note
Summary: Advanced editor - Rancor - Move syspref from labs to cataloging and remove ex...
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-27 11:38 UTC by Nick Clemens
Modified: 2018-04-12 13:13 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging' (4.06 KB, patch)
2017-10-27 11:41 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging' (4.12 KB, patch)
2017-10-28 11:05 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging' (4.17 KB, patch)
2018-04-06 17:54 UTC, Maksim Sen
Details | Diff | Splinter Review
Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging' (4.26 KB, patch)
2018-04-09 11:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2017-10-27 11:38:45 UTC
Rancor is being used by many libraries - it has not shown any destructive tendencies or caused data loss, let's make it official
Comment 1 Nick Clemens 2017-10-27 11:41:51 UTC
Created attachment 68682 [details] [review]
Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging'

To test:
1 - View sysprefs
2 - Note 'Labs' tab
3 - Note EnableAdvancedCatalogingEditor is the only pref there
4 - Note that prefs works
5 - Apply patch
6 - Note 'Labs' tab is gone
7 - Check the 'Cataloging' tab (under Interface)
8 - There it is!
9 - Verify it still works
Comment 2 Katrin Fischer 2017-10-28 11:05:29 UTC
Created attachment 68799 [details] [review]
Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging'

To test:
1 - View sysprefs
2 - Note 'Labs' tab
3 - Note EnableAdvancedCatalogingEditor is the only pref there
4 - Note that prefs works
5 - Apply patch
6 - Note 'Labs' tba is gone
7 - Check the 'Cataloging' tab (under Interface)
8 - There it is!
9 - Verify it still works

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Marcel de Rooy 2017-11-03 06:51:07 UTC
The short experiences that I have with Rancor do not provide me enough evidence that this is no longer experimental. Since we now are just adding authority support e.g., I would say this needs more time.
And above all, we need community feedback.
Comment 4 Katrin Fischer 2017-11-04 20:37:00 UTC
We discussed this at the last meeting and agreed to move it out of labs. There are no open bug reports, just ongoing enhancements. I think it's ripe to leave the labs.

https://wiki.koha-community.org/wiki/Development_IRC_meeting_11_October_2017
Comment 5 Marcel de Rooy 2018-04-06 09:06:50 UTC
Adding a functional dependency as a workaround: If authority support gets in, this can follow?
Comment 6 Maksim Sen 2018-04-06 17:54:24 UTC
Created attachment 73793 [details] [review]
Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging'

To test:
1 - View sysprefs
2 - Note 'Labs' tab
3 - Note EnableAdvancedCatalogingEditor is the only pref there
4 - Note that prefs works
5 - Apply patch
6 - Note 'Labs' tba is gone
7 - Check the 'Cataloging' tab (under Interface)
8 - There it is!
9 - Verify it still works

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>
Comment 7 Katrin Fischer 2018-04-07 10:15:39 UTC
Changing to BLOCKED, because of dependencies. This has a QA sign off and another, so can be considered Passed QA when unlocked.
Comment 8 Marcel de Rooy 2018-04-09 11:29:37 UTC
Created attachment 73859 [details] [review]
Bug 19538: Move EnableAdvancedCatalogingEdtor from 'Labs' to 'Cataloging'

To test:
1 - View sysprefs
2 - Note 'Labs' tab
3 - Note EnableAdvancedCatalogingEditor is the only pref there
4 - Note that prefs works
5 - Apply patch
6 - Note 'Labs' tba is gone
7 - Check the 'Cataloging' tab (under Interface)
8 - There it is!
9 - Verify it still works

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Jonathan Druart 2018-04-11 19:54:22 UTC
Pushed to master for 18.05, thanks to everybody involved!