Bug 19589 - DESTDIR environment variable ignored on "make install"
Summary: DESTDIR environment variable ignored on "make install"
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: 17.05
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-07 23:45 UTC by int
Modified: 2023-09-30 21:27 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description int 2017-11-07 23:45:54 UTC
(In koha-17.05.03/) when calling 
> DESTDIR=fancydir make install
the DESTDIR from the command-line is ignored and 
the empty one from Makefile is used. 
In Makefile the following line can be found
> DESTDIR = 
If this line is deleted, the DESTDIR from the command-line is used as expected.
(But I don't know if this is a good idea to do, beside that Makefile is generated.)

This behaviour is bad for package-building of koha.


Steps to reproduce:

Just follow the normal install procedure (as normal user):
> perl Makefile.PL --install_base /usr/share/koha --install_mode standard ...
> make
> DESTDIR=fancydir make install
The following error should occur:
> ERROR: Can't create '/etc/koha'
> mkdir /etc/koha: Permission denied at ...
Expected is that everything is installed below $DESTDIR/, 
e.g. $DESTDIR/etc/koha, and not root.
Comment 1 Katrin Fischer 2023-09-30 21:27:38 UTC
The line mentioned does on longer exist in Makefile. I assume this has been fixed.