Bug 19595 - Clicking plugin link does not fill item's date acquired field
Summary: Clicking plugin link does not fill item's date acquired field
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
: 19644 (view as bug list)
Depends on: 16203
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-08 17:23 UTC by Owen Leonard
Modified: 2017-12-07 14:25 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 19595: Clicking plugin link does not fill item's date acquired field (1.58 KB, patch)
2017-11-10 13:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19595: Clicking plugin link does not fill item's date acquired field (1.77 KB, patch)
2017-11-10 13:37 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2017-11-08 17:23:54 UTC
Before Bug 16203, clicking the "..." plugin link on the item add form's date acquired field would insert today's date, overwriting an existing date if present.

Now clicking the "..." link does nothing.
Comment 1 Marcel de Rooy 2017-11-09 08:03:32 UTC
I think this is not a bug but a change in behavior. We have cataloging plugins with additional popups and those without such popups. The plugin for date acquired is in the last category. More technically, it has no launcher in its perl script. If you hover your mouse over the "plugin link", you will see "No popup". Iirc another report already mentioned the need for a clearer division.

Imo no bug and no rel 17.11 candidate, but something to improve in style for 18.05.
Comment 2 Jonathan Druart 2017-11-09 12:32:49 UTC
Thanks for the clarification Marcel.
Comment 3 Owen Leonard 2017-11-09 16:42:18 UTC
I consider this a bug BECAUSE it is a change in behavior. Functionality which my catalogers used daily has been removed, making their work more difficult.
Comment 4 Jonathan Druart 2017-11-09 17:09:26 UTC
(In reply to Marcel de Rooy from comment #1)
> If you hover your mouse over the "plugin link", you will see "No popup".

I see "Tag editor"
Comment 5 Owen Leonard 2017-11-10 13:04:57 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2017-11-10 13:37:01 UTC
Created attachment 69085 [details] [review]
Bug 19595: Clicking plugin link does not fill item's date acquired field

This patch updates the dateaccessioned plugin for the item edit form to
return functionality which was removed in a previous patch.

To test, apply the patch and open an item for editing. Clicking the
"..." link next to the "Date acquired" field should insert the current
date, overwriting the existing date.

Open a blank item add form. Putting the cursor in the "Date acquired"
field should automatically insert the current date.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Added a comment line in set_to_today.
Comment 7 Marcel de Rooy 2017-11-10 13:37:53 UTC
(In reply to Jonathan Druart from comment #4)
> (In reply to Marcel de Rooy from comment #1)
> > If you hover your mouse over the "plugin link", you will see "No popup".
> 
> I see "Tag editor"

Caused by the presence of a Click event
Comment 8 Marcel de Rooy 2017-11-10 13:39:18 UTC
(In reply to Owen Leonard from comment #3)
> I consider this a bug BECAUSE it is a change in behavior. Functionality
> which my catalogers used daily has been removed, making their work more
> difficult.

There is difficult and difficult :) Clicking in the field would have triggered the Focus event, but indeed it would not overwrite. But overwriting date acquired might not be a good idea most of the time ..
Comment 9 Marcel de Rooy 2017-11-10 13:40:33 UTC
In view of its rather trivial nature, passing QA in one run.
Comment 10 Owen Leonard 2017-11-16 18:34:59 UTC
*** Bug 19644 has been marked as a duplicate of this bug. ***
Comment 11 Jonathan Druart 2017-12-07 14:25:04 UTC
Pushed to master for 18.05, thanks to everybody involved!