Bug 19640 - IdRef webservice display is broken
Summary: IdRef webservice display is broken
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin SOMERS
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on: 8992
Blocks:
  Show dependency treegraph
 
Reported: 2017-11-16 14:21 UTC by Fridolin SOMERS
Modified: 2017-12-07 12:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Display of IdRef broken (32.52 KB, image/png)
2017-11-16 14:28 UTC, Fridolin SOMERS
Details
Bug 19640: fix OPAC IdRef webservice display (3.80 KB, patch)
2017-11-16 14:58 UTC, Fridolin SOMERS
Details | Diff | Splinter Review
Bug 19640: fix OPAC IdRef webservice display (3.86 KB, patch)
2017-11-17 13:58 UTC, Simon Pouchol
Details | Diff | Splinter Review
Bug 19640: fix OPAC IdRef webservice display (4.02 KB, patch)
2017-11-24 09:30 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin SOMERS 2017-11-16 14:21:58 UTC
The OPAC webservice IdRef display is broken.
The call returns results but citations are empty.
Comment 1 Fridolin SOMERS 2017-11-16 14:28:52 UTC
Created attachment 69181 [details]
Display of IdRef broken
Comment 2 Fridolin SOMERS 2017-11-16 14:58:58 UTC
Created attachment 69182 [details] [review]
Bug 19640: fix OPAC IdRef webservice display

The OPAC webservice IdRef display was broken.
The call returns results but citations where empty.
Maybe the webservice has changed.

This patch corrects the fetch of datas in result.
Also fixes a small HTML missing tag tr.
Also adds a comment with link to official doc :
http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio

Test plan :
1) Enable system preference IdRef
2) Choose an existing PPN like 032581270
3) Look result on : https://www.idref.fr/services/biblio/032581270.json
4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
5) Without patch you see only one role containing empty rows
6) With patch you see all roles with correct rows
Comment 3 Simon Pouchol 2017-11-17 13:58:05 UTC
Created attachment 69196 [details] [review]
Bug 19640: fix OPAC IdRef webservice display

The OPAC webservice IdRef display was broken.
The call returns results but citations where empty.
Maybe the webservice has changed.

This patch corrects the fetch of datas in result.
Also fixes a small HTML missing tag tr.
Also adds a comment with link to official doc :
http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio

Test plan :
1) Enable system preference IdRef
2) Choose an existing PPN like 032581270
3) Look result on : https://www.idref.fr/services/biblio/032581270.json
4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
5) Without patch you see only one role containing empty rows
6) With patch you see all roles with correct rows

Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>
Comment 4 Marcel de Rooy 2017-11-24 09:30:36 UTC
Created attachment 69332 [details] [review]
Bug 19640: fix OPAC IdRef webservice display

The OPAC webservice IdRef display was broken.
The call returns results but citations where empty.
Maybe the webservice has changed.

This patch corrects the fetch of datas in result.
Also fixes a small HTML missing tag tr.
Also adds a comment with link to official doc :
http://documentation.abes.fr/aideidrefdeveloppeur/index.html#MicroWebBiblio

Test plan :
1) Enable system preference IdRef
2) Choose an existing PPN like 032581270
3) Look result on : https://www.idref.fr/services/biblio/032581270.json
4) Call in OPAC website : /cgi-bin/koha/opac-idref.pl?unimarc3=032581270
5) Without patch you see only one role containing empty rows
6) With patch you see all roles with correct rows

Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended: removed unused @unimarc3 (not to be confused with $unimarc3).
Comment 5 Marcel de Rooy 2017-11-24 09:33:12 UTC
Does not seem to affect translation.
Comment 6 Jonathan Druart 2017-12-07 12:40:07 UTC
Pushed to master for 18.05, thanks to everybody involved!